server icon indicating copy to clipboard operation
server copied to clipboard

Align collaborative tags differently

Open Jerome-Herbinet opened this issue 1 year ago • 4 comments

IMO, centering makes reading difficult (a bit messy, don't you think 🤔, especially because of tags length and number differences ? )

before

What I propose

Aligned to the right (currently committed in this PR) : after Or aligned to the left: 2023-06-22_16-25

Checklist

Jerome-Herbinet avatar Jun 22 '23 14:06 Jerome-Herbinet

Question : why my "npm run build" re-build dist/settings-vue-settings-personal-info.js and dist/settings-vue-settings-personal-info.js.map ? Is it normal ?

Jerome-Herbinet avatar Jun 22 '23 14:06 Jerome-Herbinet

It should be aligned right already. The file name expand and push everything to the right, the justify-content: center should not apply here. Are you on Firefox?

Ref: see screenshots from https://github.com/nextcloud/server/pull/37938

skjnldsv avatar Jun 22 '23 16:06 skjnldsv

Right, something must have slept through Can you remove the flex: 1 1 100% on the table td.filename .system-tags instead then? :) So it doesn't take more space than necessary?

image

skjnldsv avatar Jun 22 '23 16:06 skjnldsv

Question : why my "npm run build" re-build dist/settings-vue-settings-personal-info.js and dist/settings-vue-settings-personal-info.js.map ? Is it normal ?

Seems like master has a discrepancy, so you fixed it here. You can ignore, that's alright

skjnldsv avatar Jun 22 '23 16:06 skjnldsv

It should be aligned right already. The file name expand and push everything to the right, the justify-content: center should not apply here. Are you on Firefox?

Ref: see screenshots from #37938

@skjnldsv I use FF, but a new test made this morning shows up the same problem.

Jerome-Herbinet avatar Jun 23 '23 08:06 Jerome-Herbinet

Right, something must have slept through Can you remove the flex: 1 1 100% on the table td.filename .system-tags instead then? :) So it doesn't take more space than necessary?

image

@skjnldsv your suggestion was the good one. It's all folks now ! 🙂 (+ commit squashing)

Jerome-Herbinet avatar Jun 23 '23 09:06 Jerome-Herbinet

/backport to stable27

skjnldsv avatar Jun 23 '23 12:06 skjnldsv

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

/backport to stable27

solracsf avatar Jun 23 '23 16:06 solracsf

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport