server
server copied to clipboard
Align collaborative tags differently
IMO, centering makes reading difficult (a bit messy, don't you think 🤔, especially because of tags length and number differences ? )
What I propose
Aligned to the right (currently committed in this PR) :
Or aligned to the left:
Checklist
- Code is properly formatted
- Sign-off message is added to all commits
- [ ] Tests (unit, integration, api and/or acceptance) are included
- [ ] Screenshots before/after for front-end changes
- [ ] Documentation (manuals or wiki) has been updated or is not required
- [ ] Backports requested where applicable (ex: critical bugfixes)
Question : why my "npm run build" re-build dist/settings-vue-settings-personal-info.js and dist/settings-vue-settings-personal-info.js.map ? Is it normal ?
It should be aligned right already.
The file name expand and push everything to the right, the justify-content: center
should not apply here.
Are you on Firefox?
Ref: see screenshots from https://github.com/nextcloud/server/pull/37938
Right, something must have slept through
Can you remove the flex: 1 1 100%
on the table td.filename .system-tags
instead then? :)
So it doesn't take more space than necessary?
Question : why my "npm run build" re-build dist/settings-vue-settings-personal-info.js and dist/settings-vue-settings-personal-info.js.map ? Is it normal ?
Seems like master has a discrepancy, so you fixed it here. You can ignore, that's alright
It should be aligned right already. The file name expand and push everything to the right, the
justify-content: center
should not apply here. Are you on Firefox?Ref: see screenshots from #37938
@skjnldsv I use FF, but a new test made this morning shows up the same problem.
Right, something must have slept through Can you remove the
flex: 1 1 100%
on thetable td.filename .system-tags
instead then? :) So it doesn't take more space than necessary?
@skjnldsv your suggestion was the good one. It's all folks now ! 🙂 (+ commit squashing)
/backport to stable27
The backport to stable27 failed. Please do this backport manually.
# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27
More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport
/backport to stable27
The backport to stable27 failed. Please do this backport manually.
# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27
More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport