File picker dialog improvements

[jancborchardt]

How to use GitHub

• Please use the 👍 reaction to show that you are interested into the same feature.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe. The current file picker is very basic at the moment – after talking with @jospoortvliet about it we identified some improvements:

Describe the solution you'd like

• Left sidebar with the favorite folders for quick jumping
• Use same sort order as in the main Files view
• Remember last location/folder you were in, not start in root folder every time
• Ability to search in the picker
• …

What do you think @nextcloud/designers – any additional points, and who is interested in doing mockups for it? :)

[kesselb]

Remember last location/folder you were in, not start in root folder every time

https://github.com/nextcloud/server/issues/644 time goes by so fast ;)

[AndyScherzinger]

@jancborchardt since we also had this issue in the main view a while ago:

Ability to search in the picker

• 🔎Search or 🌪️_Filter_ (files currently does both, first filters current folder listing, yet searches everywhere in parallel)
• Where would you search? In the folder you are currently in? "Everywhere" files related? (bullet point (1) might implicitly answer it dep4ending on your answer to it)

[jancborchardt]

@AndyScherzinger we could start with Filter in current view rather than search. But also, out of the things listed, that is the least priority issue (also cause probably needs a lot of investment).

[nimishavijay]

Will pick this up for mockups!

Additionally, it would be great to allow sharing via link from the file picker itself wherever appropriate. Related issue: https://github.com/nextcloud/mail/issues/6080 what do you think?

[jancborchardt]

Additionally, it would be great to allow sharing via link from the file picker itself wherever appropriate. Related issue: https://github.com/nextcloud/mail/issues/6080 what do you think?

@nimishavijay sounds good as an additional optional mockup, yep! :)

[AndyScherzinger]

please align any specific @nimishavijay and @susnux - I guess sorting and remembering the last location are clear - however I would challenge the sorting part, but will do in the respective ticket.

[nimishavijay]

@susnux The new file picker can look like this:

• [x] A similar layout to the settings modal is used to mimic the files app layout, with a navigation on the left containing:
  • [x] All files
  • [x] Recent
  • [x] Favorites
• [ ] The rest of the modal contains the content
  • [x] If "All files" is chosen, the breadcrumbs are shown with the file list
  • [x] If "Recent" is chosen, a heading "Recent items" is shown and the recent files list
  • [x] If "Favorites" is chosen, a heading "Favorites" and the list of favorites
  • [x] The new breadcrumbs component is used
  • [ ] Updated icons in file list: 20px MDI folder icon
  • [x] Remove the lines in between each item
  • [ ] https://github.com/nextcloud/server/issues/39185
  • [x] https://github.com/nextcloud/server/issues/39186

Nice-to-haves

• [x] https://github.com/nextcloud/server/issues/39187 : the first item of the navigation can be a search bar which allows you to search for a file (across all your files)

• [ ] https://github.com/nextcloud/mail/issues/6080 Wherever applicable, there could be the option to share a link from within the file picker. Currently, for eg. in Mail, you have the option to choose that you want to share a link, and then the file picker opens, while this flow can be simplified by just having the option to share link from within the file picker anyway.

[AndyScherzinger]

@nimishavijay @jancborchardt just since it got phrased differently in the latest mock up and description: Search should just be filtering for the moment and filtering would be on the current listing, no actual search on all your accessible files.

[nimishavijay]

@AndyScherzinger understood. then to indicate that search has been applied only on the current listing, the Search results for "design" heading can be under the breadcrumbs bar in the all files view and in the heading with a dot separator in recent and favorites (Recent items · Search results for "design"). cc @susnux and @nextcloud/designers

[marcoambrosini]

@nimishavijay I would strongly recommend to have the search-box on top of the search results like in some of your other mockups. I find it very counterintuitive that the search-box is filtering a list that it's not directly below it.

If the search-box was directly above the results, I think that there would be less need for a heading indicating that a filter is active, and it would be enough to have a search in "design" placeholder within the search input.

[susnux]

I like the design and it looks consistent :) But for mobile I am not sure how this should look like. Should the left side menu simply be moved as a horizontal menu underneath the title (between title and current path)?

Because for the app settings, the left side simply is removed.

[nimishavijay]

But for mobile I am not sure how this should look like. Should the left side menu simply be moved as a horizontal menu underneath the title (between title and current path)?

As discussed yesterday it can be a dropdown item which is shown above the breadcrumbs bar :)