server icon indicating copy to clipboard operation
server copied to clipboard

fix(sab): put location in proper address field

Open JohannesGGE opened this issue 2 years ago • 4 comments

  • Resolves: https://github.com/nextcloud/contacts/issues/3404

Summary

before after
image image
image image

Checklist

JohannesGGE avatar Jun 16 '23 12:06 JohannesGGE

it wasn't assumed the profile Location field was a city before, so this seems a little problematic for people who entered a full street address in that field.

Yeah. I think no matter how we name or hint the profile property, it's never going to be perfect.

Ref https://github.com/nextcloud/contacts/issues/3404#issuecomment-1563406849

ChristophWurst avatar Jun 16 '23 15:06 ChristophWurst

Thx for context!

tcitworld avatar Jun 16 '23 15:06 tcitworld

/backport to stable27

ChristophWurst avatar Jun 19 '23 09:06 ChristophWurst

Replaced null with '' to make pipeline (phpunit) happy

JohannesGGE avatar Jun 20 '23 13:06 JohannesGGE

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport