server icon indicating copy to clipboard operation
server copied to clipboard

align subadmins css class name

Open Jenandra opened this issue 1 year ago • 1 comments

Summary

The actually used class name in apps/settings/src/components/UserList/UserRowSimple.vue is subAdminsGroups. Because of this, css for the subadmins groups column in the user list is missing, causing formatting to break when users are admins of many (10+) groups.

See also: https://help.nextcloud.com/t/ansicht-von-user-mit-vielen-gruppen-ist-unubersichtlich/72149/3

Jenandra avatar Jun 13 '23 12:06 Jenandra

Don't .subadmin target other elements? Why don't the component declare its own css?

You're perfectly right, I seem to have missed the spots where the subadmins class is actually used. I've duplicated the css now so both class names work, thanks!

Jenandra avatar Jun 14 '23 14:06 Jenandra

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

welcome[bot] avatar Jun 16 '23 08:06 welcome[bot]

Thanks @Jenandra !

artonge avatar Jun 16 '23 08:06 artonge