server icon indicating copy to clipboard operation
server copied to clipboard

enh(contacts): show/hide addressbooks for all

Open JohannesGGE opened this issue 2 years ago • 3 comments

  • Fixes https://github.com/nextcloud/contacts/issues/479

Summary

TODO

  • [ ] ...

Checklist

JohannesGGE avatar May 22 '23 13:05 JohannesGGE

Due to the different implementation of the recently contacted addressbook, the call for changing the enabled property can't be executed, and an "addressbook is immutable" is thrown in apps/contactsinteraction/lib/AddressBook.php::propPatch().

Other addressbooks call apps/dav/lib/CardDAV/AddressBook.php::propPatch()

As far as I can tell the only needed code is the DB update of apps/dav/lib/DAV/CustomPropertiesBackend.php::updateProperties() to have a working enable/disable for the recently contacted addressbook.

JohannesGGE avatar May 22 '23 14:05 JohannesGGE

Recently contacted address book will be tackled in another issue.

JohannesGGE avatar May 23 '23 18:05 JohannesGGE

The addressbook is now checked for sharing. If it is shared the props will be saved as userProps. So even if the addressbook is renamed by user that is not the owner (not possible in the contacts app yet), the owners addressbook name isn't changed. For the case the addressbook has a userProp name, this name is shown now.

JohannesGGE avatar Jun 02 '23 10:06 JohannesGGE

nitpick: enh(contacts) should be feat(contacts) according to https://www.conventionalcommits.org/en/v1.0.0/

kesselb avatar Jul 18 '23 14:07 kesselb

/backport to stable27

miaulalala avatar Aug 16 '23 10:08 miaulalala