server icon indicating copy to clipboard operation
server copied to clipboard

Published 20 hours ago • verified publisher icon nextcloud

fix(theming): unwanted variables and colours calc fixes

Open skjnldsv opened this issue 1 year ago • 5 comments

Fix https://github.com/nextcloud/server/issues/37656

If the admin previously uploaded an image, it is not being deleted when the background is set to color only. Meaning --image-background was being defined anyway Now it is being defined but we ensure it is set to no, an invalid value, when the bg is deleted

Fix https://github.com/nextcloud/server/issues/38061

We were not passing the current main background to the elementColor function, meaning we were not benefiting from the max/min contrast. Now we do. If a value is too bright or too dark, the color will be replaced to ensure proper contrast.

skjnldsv avatar May 04 '23 08:05 skjnldsv

We were not passing the current main background to the elementColor function, meaning we were not benefiting from the max/min contrast. Now we do. If a value is too bright or too dark, the color will be replaced to ensure proper contrast.

Doesnt seem to fix the problem in my testing: image

szaimen avatar May 04 '23 08:05 szaimen

If the admin previously uploaded an image, it is not being deleted when the background is set to color only. Meaning --image-background was being defined anyway Now it is being defined but we ensure it is set to no, an invalid value, when the bg is deleted

seems to work but when the admin uploads a background image and then clicks on delete (so that only the background color stays) the by the admin uploaded image will still be shown as standard background even though it was removed: image

szaimen avatar May 04 '23 08:05 szaimen

the by the admin uploaded image will still be shown as standard background even though it was removed

Nice catch! Let me fix too

Doesnt seem to fix the problem in my testing:

What should I see in your screenshot?

skjnldsv avatar May 04 '23 10:05 skjnldsv

What should I see in your screenshot?

The buttons should have a more greyish color to better distinguish them from the background even if the primary color is set to black?

szaimen avatar May 04 '23 10:05 szaimen

What should I see in your screenshot?

The buttons should have a more greyish color to better distinguish them from the background even if the primary color is set to black?

Well, those buttons uses primary css variables that are not made for elements image

That needs to be fixed in the vue components then :)

skjnldsv avatar May 04 '23 11:05 skjnldsv

/backport to stable26

skjnldsv avatar May 05 '23 11:05 skjnldsv