follow-up to files_trashbin to vue migration

[szaimen]

Follow-ups to https://github.com/nextcloud/server/pull/36534

Bugfixes:

• [x] Improve loading indicator for actions
• [x] Breadcrumbs show Foldername.dTIMESTAMP when browsing a deleted folder, in the old implementation we just showed Foldername
• [x] Clicking on a file in the trashbin downloads the file but with incorrect extension
• [x] Switching back to other file list does not work once entered the trash bin once
• [x] Restore/delete permanently a file does not remove it from the list

Missing:

• [ ] Grid view not implemented
• [x] Hide some columns on small screens
• [x] Right-click does not work anymore

Enhancements:

• [ ] Deepen virtual scrolling performances
• [ ] Implement keyboard arrow/pageUp-Down navigation and focus management

Others:

• [ ] it feels strange that the right-click menu gets opened not directly at the tooltip but at where the expand button is triggered

[szaimen]

~~@skjnldsv I am not sure if it is related to the trashbin migration but uploading any folder into the files app now results in conflicts and a NotFoundError files getting created multiple times.~~ Looks like this is unrelated because I could reproduce this already on nc26 and nc25

[joshtrichards]

This is great. Glad to see the trash bin getting some love (hah).

Question: Is there a reason Download is the new default behavior for clicking the filename rather than opening the file?

Seems like Download would just be another option like Restore and Delete. Whereas clicking on filename itself would open the file. Would address #19353 as well as be more consistent with Files UI behavior / experience.

[skjnldsv]

@joshtrichards the trashbin never had any default action. Clicking did nothing with 25 and earlier versions. It's therefore not a regression or a change. But at least it makes it easier to access deleted files, instead of having to restore to view/check them :)

[joshtrichards]

Definitely an improvement. I could have worded my query better. I wasn't suggesting it was a regression or change. I get clicking on filename in the trashbin was a no-op before (so download is an improvement).

But in Files, clicking a filename typically opens a file for viewing (well, or editing) rather than downloading. I was trying to understand if it was a deliberate choice to do Download as the default action in the trashbin rather than viewer/edit mode like in Files generally.

[skjnldsv]

All good :) https://github.com/nextcloud/server/issues/1071 would be the proper ticket to wait for then :+1:

[skjnldsv]

https://github.com/nextcloud/server/issues/39914