server icon indicating copy to clipboard operation
server copied to clipboard

fix(provisionning_api): Remove parameters that are not set into template

Open tcitworld opened this issue 2 years ago • 6 comments

Summary

Fixes

  • Notice: Undefined index: parameters
  • Warning: Invalid argument supplied for foreach()
  • Undefined index: targetUrl at /var/www/nc/nextcloud/core/templates/confirmation.php#9

The template is only called by the Provisioning API in apps/provisioning_api/lib/Controller/VerificationController.php, brought in https://github.com/nextcloud/server/pull/28422.

Checklist

tcitworld avatar Mar 20 '23 13:03 tcitworld

/backport to stable26

tcitworld avatar Mar 20 '23 13:03 tcitworld

/backport to stable27

tcitworld avatar Feb 01 '24 17:02 tcitworld

/backport to stable28

tcitworld avatar Feb 01 '24 17:02 tcitworld

Since it's pretty clear this thing is not used from any other point, let's move it also into the app, to avoid it being in core/ and therefore seen as "public API"

nickvergessen avatar Feb 02 '24 14:02 nickvergessen