server icon indicating copy to clipboard operation
server copied to clipboard

Make sure to never trigger files hooks on a null path

Open come-nc opened this issue 1 year ago • 7 comments

  • Resolves: #34932

Summary

File pre/post operation events should only be triggered for files inside the default view. For other files a bogus event with a null path was fired, this avoids that.

Checklist

come-nc avatar Feb 28 '23 11:02 come-nc

  • [x] Need https://github.com/nextcloud/server/pull/36836 first to avoid type errors

come-nc avatar Feb 28 '23 13:02 come-nc

Thank you so much for the fix. I am really needing this fix because of issues with syncing bigger files.

tram98 avatar Mar 04 '23 01:03 tram98

/rebase

come-nc avatar Apr 05 '23 09:04 come-nc

/rebase

come-nc avatar May 02 '23 16:05 come-nc

/rebase

come-nc avatar May 04 '23 13:05 come-nc

Apologies for my lack of experience with GitHub and NC development, but will this only be pushed into Nextcloud 27 and not in a 26.0.x patch?

dinosmm avatar May 04 '23 14:05 dinosmm

will this only be pushed into Nextcloud 27 and not in a 26.0.x patch?

Yes this will first be pushed into Nextcloud 27 and might then be backported to 26.0.x.

susnux avatar May 04 '23 14:05 susnux

@come-nc OK to be backported?

solracsf avatar May 09 '23 16:05 solracsf

Hum yeah psalm will complain about the backports I think because typing was hell, but let’s try it.

come-nc avatar May 11 '23 14:05 come-nc

/backport to stable26

come-nc avatar May 11 '23 14:05 come-nc

/backport to stable25

come-nc avatar May 11 '23 14:05 come-nc