[stable25] Backport: Make the container fully fulfill PSR container interface

[susnux]

• Resolves: Backport of #36417

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• [ ] Tests (unit, integration, api and/or acceptance) are included
• [x] Documentation (manuals or wiki) has been updated or is not required
• [x] Backports requested where applicable (ex: critical bugfixes)

[susnux]

To fix the psalm errors we would have to either update the psr container to 1.1.2. But somehow it does not complain about the @throws ContainerExceptionInterface which was there before and did not extend Throwable either.

[blizzz]

CI unhappy, moving to 25.0.5

[susnux]

The OCP psalm check succeeds, but there seem to be unrelated other issues (not touched that code).

[blizzz]

/rebase

[susnux]

/rebase

@blizzz Did not work, so I rebased it manually.

[come-nc]

I do not understand what the hell is happenning to psalm here. It’s removing stuff from the baseline and then complaining about it?

[susnux]

I do not understand what the hell is happenning to psalm here. It’s removing stuff from the baseline and then complaining about it?

@come-nc I resolved this. It happened because updating the psr container also triggered updating psalm from 4.18.1 to 4.30.0. This caused psalm to report new (?) errors. So I reverted the update of psalm.

But I still have no clue why cs fixer is failing, the reported files are unchanged (even if cs fixer is right about the wrong code style within those files)... :point_left: fixed

[nickvergessen]

❌ Branch is currently frozen

[susnux]

@nickvergessen branch is no longer frozen

drone failure is unrelated

[blizzz]

just merged 3rdparty PR. Rebase needed?

[susnux]

just merged 3rdparty PR. Rebase needed?

@blizzz Done