server icon indicating copy to clipboard operation
server copied to clipboard

Format of Databasehost for Sockets

Open obel1x opened this issue 3 years ago • 3 comments

  • Resolves: #35378

Summary

First, the Documentation was wrong for the dbhost in config.php when using sockets and second, made the installer accept the filename without adding "localhost:" in front, which is uncommon so not intuitive and not documented.

TODO

nothing.

Checklist

X Code is properly formatted X Sign-off message is added to all commits

  • [?] Tests (unit, integration, api and/or acceptance) are included
  • [-] Screenshots before/after for front-end changes
  • [X] Documentation (manuals or wiki) has been updated or is not required
  • [?] Backports requested where applicable (ex: critical bugfixes)

obel1x avatar Dec 26 '22 11:12 obel1x

@kesselb this redoes my broken pull https://github.com/nextcloud/server/pull/35379 . Hope now its fine and thank you for your patience, i am getting used to git and eclipse slowly ;)

obel1x avatar Dec 26 '22 11:12 obel1x

Thank you @obel1x

kesselb avatar Dec 27 '22 14:12 kesselb

turned out to be more tricky, as the value is written to config and needs to be read from there in the same style. So now it should both work in config which makes it more styled like in other configs and better for new users. Those should both work e.g.:

  • 'dbhost' => 'localhost:/run/mysql/mysql.sock' (old style)
  • 'dbhost' => '/run/mysql/mysql.sock' (new optional style)

obel1x avatar Dec 27 '22 18:12 obel1x