server icon indicating copy to clipboard operation
server copied to clipboard

feat(appframework): ⌚ Make ITimeFactory extend \PSR\Clock\ClockInterface

Open nickvergessen opened this issue 3 years ago • 2 comments

Summary

  • ITimeFactory now implements PSR-20: https://www.php-fig.org/psr/psr-20/#21-clockinterface

TODO

  • [ ] 3rdparty https://github.com/nextcloud/3rdparty/pull/1262
  • [ ] OCP update so Psalm can find the interface https://github.com/nextcloud-deps/ocp/pull/4

Checklist

nickvergessen avatar Dec 22 '22 19:12 nickvergessen

Might or might not make sense to deprecate getTime right away.

ChristophWurst avatar Dec 23 '22 14:12 ChristophWurst

Might or might not make sense to deprecate getTime right away.

Same for the getDateTime() I think

nickvergessen avatar Dec 23 '22 15:12 nickvergessen

I would love to see this documented at https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/psr.html :)

ChristophWurst avatar Jan 09 '23 15:01 ChristophWurst

Will do, after it's merged

nickvergessen avatar Jan 09 '23 16:01 nickvergessen

Rebased, now that 7.4 is dropped

nickvergessen avatar Jan 23 '23 10:01 nickvergessen

Dang, this slipped through. To preserve stability in OCP, I'm moving it to 27

nickvergessen avatar Feb 23 '23 15:02 nickvergessen

Docs in https://github.com/nextcloud/server/issues/37039#issuecomment-1455724716 and https://github.com/nextcloud/documentation/pull/9722

nickvergessen avatar Mar 06 '23 09:03 nickvergessen