server
server copied to clipboard
nextcloud
[stable25] Quota value as float for 32-bit systems
- Resolves: https://github.com/nextcloud/server/issues/34010#issuecomment-1345691736
Summary
TODO
Checklist
- Code is properly formatted
- Sign-off message is added to all commits
- [x] Tests (unit, integration, api and/or acceptance) are included => n/a
- [x] Screenshots before/after for front-end changes => n/a
- [x] Documentation (manuals or wiki) has been updated or is not required => n/a
- [x] Backports requested where applicable (ex: critical bugfixes)
@PVince81 I am under the impression that this error does again only happen on 32-bit due to the php int limit. Are you sure that this does not break on 64-bit?
same problem here... "message":"Typed property OC\Files\Storage\Wrapper\Quota::$quota must be int or null, float used in file '/var/www/html/nextcloud/lib/private/Files/Storage/Wrapper/Quota.php
We should just remove the type hint and only use a phpdoc type hint of int|float, with an explanation that it may be float on 32bits.
Sounds good to me 👍
我什么都不懂，麻烦你了，，帮帮我
346354343 @.***
------------------ 原始邮件 ------------------ 发件人: "nextcloud/server" @.>; 发送时间: 2022年12月12日(星期一) 晚上7:15 @.>; @.***>; 主题： 回复：[nextcloud/server] [stable25] 32 位系统的浮点配额值（PR #35734）
我们应该只删除类型提示，只使用 int|float 的 phpdoc 类型提示，并说明它可能在 32 位上是浮点数。
听起来不错👍
— 直接回复此邮件，在 GitHub 上查看，或取消订阅。 您收到此消息是因为您订阅了此线程。Message ID: @.***>
@homeessentials1 @emc02
cd /path/to/nextcloud
curl -L https://github.com/nextcloud/server/pull/35734.patch -o 35734-quota-32bit-fix.patch
patch -p1 < 35734-quota-32bit-fix.patch
can someone else take over, possibly someone with access to a 32-bit system ? I don't have time to dig deeper and try every combination. We need a solution that works both for 32-bit and 64-bit systems, for positive and negative quota values (negative values are for special cases like "unlimied")
can someone else take over,
I am sorry, I have not the experience to do that, but I can test various possible solutions if wanted and report back
it looks like so far there were three solutions:
- no type: causing warnings ?
- float: breaking negative values ?
- int: broke with 32-bits
maybe more changes are needed
@come-nc can you take over maybe ?
@come-nc can you take over maybe ?
Next week if I have the time, I will. I think we should setup a 32bit CI for stable25.
@come-nc can you take over maybe ?
Next week if I have the time, I will.
I think we should setup a 32bit CI for stable25.
Glad we have next week already 😀 Not kidding: few of my users are basically unable to use NC (no files shown at all) since v25. What else can 32 bit users test?!! I'm at a "it couldn't get any worse" position, so let's go.
Glad we have next week already grinning Not kidding: few of my users are basically unable to use NC (no files shown at all) since v25. What else can 32 bit users test?!! I'm at a "it couldn't get any worse" position, so let's go.
Well I did take over, but I cannot test as I do not have any 32bits system so I am waiting for people to test this and tell me if it’s good to merge.
@lapineige Are you able to test this on a 32-bit system, e.g. using the PR's patch: https://github.com/nextcloud/server/pull/35734#issuecomment-1349119926
I sadly forgot to enable remote SSH for my 32-bit home server and are on vacation until January.
@lapineige Are you able to test this on a 32-bit system, e.g. using the PR's patch: #35734 (comment)
I sadly forgot to enable remote SSH for my 32-bit home server and are on vacation until January.
Tried the patch: Changing quota to unlimited works changing quota to any other value results in zero quota and "Space Full"
no entrys in Log
@MichaIng : Can I do that if I already manually patched it with https://github.com/nextcloud/server/pull/34905#issuecomment-1345388301 ?
Tried the patch: Changing quota to unlimited works changing quota to any other value results in zero quota and "Space Full"
no entrys in Log
Did the whole patch apply without errors?
@MichaIng : Can I do that if I already manually patched it with #34905 (comment) ?
No most likely the patch will not apply, you would need to reverse the first patch with "patch -R" first if possible. Or to start back from last Nextcloud 25.
Tried the patch: Changing quota to unlimited works changing quota to any other value results in zero quota and "Space Full" no entrys in Log
Did the whole patch apply without errors?
Did a clean install of 25.0.2 and applied the patch. All items were successfully and without errors.
you would need to reverse the first patch with "patch -R" first if possible
That would be manual, due to broken syntax in the github message I did it by hand.
I'm not willing to try until a few days, to have time to work on it, in case it fails…
I can try everything :-D It's just a testing instance. So provide me some possible solutions and I'll test it!
changing quota to any other value results in zero quota and "Space Full"
This is still true? Strange as https://github.com/nextcloud/server/pull/34905#issuecomment-1345388301 does work 🤔.
Tested patch 35734 on 32-bit system and it fixes the issue (login is possible again for users with a 10 GB quota). Do you still need help for some specific tests? I have access to both 32- and 64-bit test systems.
Tested patch 35734 on 32-bit system and it fixes the issue (login is possible again for users with a 10 GB quota). Do you still need help for some specific tests? I have access to both 32- and 64-bit test systems.
I would like to know if with the patch there are still issues or not. Some people said the quota display was broken, is that fixed as well with the patch?
And I would love if someone could run the test suite on 32bits and tell me if there are errors/failures.
Running ./autotest.sh sqlite tests/lib/Files should be enough as quota related tests should be in this folder.
Just as a quick answer: Quota display is fine with the patch at 32-bit, can't run the test at the moment.
@homeessentials1 @emc02
cd /path/to/nextcloudcurl -L https://github.com/nextcloud/server/pull/35734.patch -o 35734-quota-32bit-fix.patchpatch -p1 < 35734-quota-32bit-fix.patch
Work for me. Thank you.
When this get merged, can we expect it to be released with an upcoming 25.x point release ?
When this get merged, can we expect it to be released with an upcoming 25.x point release ?
yes, it will be included in 25.0.3
25.0.3 on 32bit Debian.. issue persists; setting a quota results in "0 B" or "1 GB"
Same here, Nextcloud 25.0.3 installed with Yunohost : https://github.com/YunoHost-Apps/nextcloud_ynh/pull/532