server icon indicating copy to clipboard operation
server copied to clipboard

Replace custom tooltips with native one in vue components and views

Open JuliaKirschenheuter opened this issue 2 years ago • 3 comments

Fixes https://github.com/nextcloud/server/issues/35654

  • [x] Blocked: https://github.com/nextcloud/nextcloud-vue/pull/3569 (v7.3.0)

Before example:

Screenshot from 2022-12-08 13-46-45

Screenshot from 2022-12-09 11-37-19

After example:

Screenshot from 2022-12-09 09-24-32 Screenshot from 2022-12-09 09-24-55

Screenshot from 2022-12-09 11-38-06

Summary

  • [ ] Replace custom tooltips with native one in vue components and views
  • [ ] Fix bug with wrong appearing notifications by setting password
  • [ ] Add aria-label as same as tooltip message

Checklist

JuliaKirschenheuter avatar Dec 07 '22 16:12 JuliaKirschenheuter

/backport to stable25

JuliaKirschenheuter avatar Dec 14 '22 12:12 JuliaKirschenheuter

I think we can merge this PR even if it needs a release of NC Vue. Changes from https://github.com/nextcloud/nextcloud-vue/pull/3569 are relevant for correct showing of native tooltips but also causes no errors without released NC Vue. I've put a checkbox https://github.com/nextcloud/server/issues/35654#issue-1482312101 and will reopen this issue as far this PR got merged.

JuliaKirschenheuter avatar Dec 22 '22 15:12 JuliaKirschenheuter

vue component has been released with fix, v.7.3.0

AndyScherzinger avatar Dec 23 '22 16:12 AndyScherzinger

  • master 7.3.0 update: https://github.com/nextcloud/server/pull/35996
  • stable25: https://github.com/nextcloud/server/pull/35997

PVince81 avatar Jan 04 '23 15:01 PVince81

rebased and recompiled

PVince81 avatar Jan 05 '23 07:01 PVince81

FYI this caused a regression affecting master and all versions (v26, v25): https://github.com/nextcloud/server/issues/38157

solracsf avatar May 17 '23 20:05 solracsf