server icon indicating copy to clipboard operation
server copied to clipboard

Published 20 hours ago • verified publisher icon nextcloud

Fix navigation pixel flickering

Open skjnldsv opened this issue 2 years ago • 9 comments

fix https://github.com/nextcloud/server/issues/34591

Margin is not included in the hovering.

skjnldsv avatar Oct 14 '22 12:10 skjnldsv

/backport to stable25

skjnldsv avatar Oct 14 '22 12:10 skjnldsv

/rebase

skjnldsv avatar Oct 18 '22 08:10 skjnldsv

The PR is not compiled. Did you compile locally?

nickvergessen avatar Oct 18 '22 18:10 nickvergessen

The PR is not compiled. Did you compile locally?

yes, I did

szaimen avatar Oct 18 '22 18:10 szaimen

however if Julius found that it works for him in testing, I am fine with the change

szaimen avatar Oct 18 '22 18:10 szaimen

Can you try again @szaimen ?

skjnldsv avatar Oct 26 '22 15:10 skjnldsv

/rebase

skjnldsv avatar Oct 26 '22 15:10 skjnldsv

I can still reproduce this issue with this branch. Just tried again.

szaimen avatar Oct 26 '22 15:10 szaimen

This is my test instance and even tried in a new incognito tab and session.

docker run -it \
	--name nextcloud-easy-test \
	-p 127.0.0.1:8443:443 \
	-e SERVER_BRANCH=fix/navigation-flicker \
	-e COMPILE_SERVER=1 \
	--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
	ghcr.io/szaimen/nextcloud-easy-test:latest

szaimen avatar Oct 26 '22 15:10 szaimen