server icon indicating copy to clipboard operation
server copied to clipboard

Add support for application/scim+json

Open mrstanb opened this issue 3 years ago • 2 comments

This pull request aims to resolve issue #33973 regarding the problem of accessing a JSON request body when Content-Type is set to application/scim+json.

@CarlSchwan could you maybe do a review and check whether this PR introduces a fix for the issue, as you suggested in the issue itself?

mrstanb avatar Sep 21 '22 07:09 mrstanb

Just an idea. Wouldn't be better to use generic regex like application\/(\w+\+)?json to cover potential future cases ?

hrenard avatar Sep 21 '22 11:09 hrenard

Just an idea. Wouldn't be better to use generic regex like application\/(\w+\+)?json to cover potential future cases ?

I think that'd make sense, since iirc all content types that have something to do with JSON are exactly with such a name that would be covered by the regex. If the reviewers think it makes sense, I would also consider this as a solution approach.

mrstanb avatar Sep 21 '22 12:09 mrstanb

Quick question: is there anything left which would still need to be done and taken care of before the PR could be reviewed again by the respective people, assigned as reviewers? Thanks!

mrstanb avatar Oct 27 '22 15:10 mrstanb

Can this please be looked into and merged or directions given if anything else is needed in the PR? This exact thing is totally blocking us from using the Azure AD SCIM provisioning with Nextcloud. A complete showstopper, so it would be good to get this into the next NC release! 👍

rawtaz avatar Nov 24 '22 19:11 rawtaz

@nickvergessen Thanks for the review! I incorporated the suggested changes :)

mrstanb avatar Dec 08 '22 17:12 mrstanb

There was a minor conflict in the RequestTest class between this PR's branch and the master branch which should be now resolved.

mrstanb avatar Dec 19 '22 08:12 mrstanb

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

welcome[bot] avatar Dec 20 '22 07:12 welcome[bot]

/backport to stable25

mrstanb avatar Sep 05 '23 07:09 mrstanb

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport