server icon indicating copy to clipboard operation
server copied to clipboard

User list : User name and Display name visibility improvement

Open Jerome-Herbinet opened this issue 3 years ago • 4 comments

Signed-off-by: Jérôme Herbinet [email protected]

Signed-off-by: Jérôme Herbinet [email protected]

Jerome-Herbinet avatar Sep 20 '22 13:09 Jerome-Herbinet

@szaimen (following our conversation a few minutes ago) I've closed my old messy PR (#33669) and I've created this brand new one, with exactly the same changes. It of course takes in account the design feedback of @jancborchardt. I think that everything should be OK (hoping it's not too late for Nextcloud 25).

Jerome-Herbinet avatar Sep 20 '22 14:09 Jerome-Herbinet

@szaimen (following our conversation a few minutes ago) I've closed my old messy PR (#33669) and I've created this brand new one, with exactly the same changes. It of course takes in account the design feedback of @jancborchardt. I think that everything should be OK (hoping it's not too late for Nextcloud 25).

Thank you! Yes, the PR looks good to me. However I fear we need the compiled js. Can you please run npm run build and commit the changes to this branch?

szaimen avatar Sep 20 '22 14:09 szaimen

@szaimen (following our conversation a few minutes ago) I've closed my old messy PR (#33669) and I've created this brand new one, with exactly the same changes. It of course takes in account the design feedback of @jancborchardt. I think that everything should be OK (hoping it's not too late for Nextcloud 25).

Thank you! Yes, the PR looks good to me. However I fear we need the compiled js. Can you please run npm run build and commit the changes to this branch?

OK @szaimen, it's done.

Jerome-Herbinet avatar Sep 21 '22 08:09 Jerome-Herbinet

OK @szaimen, it's done.

Thanks! However a npm run sass and commiting the changed files is unfortunately needed as well. Afterwarsa the node test should be green.

szaimen avatar Sep 21 '22 12:09 szaimen

OK @szaimen, it's done.

OK @szaimen, it's done for this as well :-)

Jerome-Herbinet avatar Sep 22 '22 08:09 Jerome-Herbinet

Thanks! I'll review and test it out later on!

szaimen avatar Sep 23 '22 06:09 szaimen

This is how it looks now: image

szaimen avatar Sep 26 '22 12:09 szaimen

CI failure unrelated

szaimen avatar Sep 26 '22 19:09 szaimen

Thanks for you patience and effort @Jerome-Herbinet !

szaimen avatar Sep 26 '22 19:09 szaimen