User list : User name and Display name visibility improvement
@szaimen (following our conversation a few minutes ago) I've closed my old messy PR (#33669) and I've created this brand new one, with exactly the same changes. It of course takes in account the design feedback of @jancborchardt. I think that everything should be OK (hoping it's not too late for Nextcloud 25).
@szaimen (following our conversation a few minutes ago) I've closed my old messy PR (#33669) and I've created this brand new one, with exactly the same changes. It of course takes in account the design feedback of @jancborchardt. I think that everything should be OK (hoping it's not too late for Nextcloud 25).
Thank you! Yes, the PR looks good to me. However I fear we need the compiled js. Can you please run npm run build and commit the changes to this branch?
@szaimen (following our conversation a few minutes ago) I've closed my old messy PR (#33669) and I've created this brand new one, with exactly the same changes. It of course takes in account the design feedback of @jancborchardt. I think that everything should be OK (hoping it's not too late for Nextcloud 25).
Thank you! Yes, the PR looks good to me. However I fear we need the compiled js. Can you please run
npm run buildand commit the changes to this branch?
OK @szaimen, it's done.
OK @szaimen, it's done.
Thanks! However a npm run sass and commiting the changed files is unfortunately needed as well. Afterwarsa the node test should be green.
OK @szaimen, it's done.
OK @szaimen, it's done for this as well :-)
Thanks! I'll review and test it out later on!
This is how it looks now:

CI failure unrelated
Thanks for you patience and effort @Jerome-Herbinet !