server icon indicating copy to clipboard operation
server copied to clipboard

Published 20 hours ago • verified publisher icon nextcloud

handle cases where SharedStorage::init isn't initializing the storage

Open icewind1991 opened this issue 3 years ago • 3 comments

Signed-off-by: Robin Appelman [email protected]

icewind1991 avatar Sep 08 '22 15:09 icewind1991

weird:

1) OCA\Provisioning_API\Tests\Controller\UsersControllerTest::testAddUserAlreadyExisting
Failed asserting that exception of type "Error" matches expected exception "OCP\AppFramework\OCS\OCSException". Message was: "Call to a member function t() on null" at
/drone/src/apps/provisioning_api/lib/Controller/UsersController.php:353
/drone/src/apps/provisioning_api/tests/Controller/UsersControllerTest.php:271
.

PVince81 avatar Sep 19 '22 12:09 PVince81

/rebase

PVince81 avatar Sep 19 '22 12:09 PVince81 

1) OCA\Provisioning_API\Tests\Controller\UsersControllerTest::testAddUserAlreadyExisting
Failed asserting that exception of type "Error" matches expected exception "OCP\AppFramework\OCS\OCSException". Message was: "Call to a member function t() on null" at
/drone/src/apps/provisioning_api/lib/Controller/UsersController.php:353
/drone/src/apps/provisioning_api/tests/Controller/UsersControllerTest.php:271
.

Fixed on master in https://github.com/nextcloud/server/pull/33502/commits/4de19e9f851e2d1948d2af4dfcd70a5b22ae53cb

Pytal avatar Sep 19 '22 18:09 Pytal

@icewind1991 is this still valid or did we fix this in a different way ? possibly through https://github.com/nextcloud/server/pull/35218

PVince81 avatar Dec 16 '22 16:12 PVince81