server icon indicating copy to clipboard operation
server copied to clipboard

Fix add user dialog

Open CarlSchwan opened this issue 3 years ago • 5 comments

  • Add label instead of placeholder for accessibility
  • Port to new vue components

CarlSchwan avatar Sep 08 '22 13:09 CarlSchwan

the multiselect looks strange but I guess it will be improved with the next beta release of vue 7.0, correct?

szaimen avatar Sep 08 '22 14:09 szaimen

Let's get this in after https://github.com/nextcloud/server/pull/34044

Pytal avatar Sep 13 '22 02:09 Pytal

/compile amend /

CarlSchwan avatar Sep 15 '22 18:09 CarlSchwan

  • [ ] BUG: dialog doesn't close after creating a user, it just empties itself (same with an without the admin password prompt)

PVince81 avatar Sep 16 '22 12:09 PVince81

  • [ ] BUG: dialog doesn't close after creating a user, it just empties itself (same with an without the admin password prompt)

Maybe something wrong with resetting the focus or something?


Also, can we remove the custom multiselect styling and check if it improves the look?

szaimen avatar Sep 17 '22 18:09 szaimen

@CarlSchwan what is missing here?

szaimen avatar Oct 20 '22 22:10 szaimen

@Pytal please take over when the time is right as it touches accessibility

PVince81 avatar Dec 16 '22 16:12 PVince81

Now that we updated nextcloud/vue miltiple times in the meantime, maybe even a rebase already makes it work...

szaimen avatar Dec 17 '22 10:12 szaimen

I rebase this and pushed the changes to https://github.com/nextcloud/server/pull/35898

szaimen avatar Dec 27 '22 16:12 szaimen