server icon indicating copy to clipboard operation
server copied to clipboard

[Bug]: user_ldap invalid translation throws error

Open susnux opened this issue 2 years ago • 0 comments

⚠️ This issue respects the following points: ⚠️

  • [X] This is a bug, not a question or a configuration/webserver/proxy issue.
  • [X] This issue is not already reported on Github (I've searched it).
  • [X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • [X] Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • [X] I agree to follow Nextcloud's Code of Conduct.

Bug description

When using the ldap user backend and setting the language to German the button for checking the settings and getting the user count does not work.

It throws following error:

"url":"/apps/user_ldap/ajax/wizard.php",
"message":"The arguments array must contain 2 items, 1 given",
"exception":{"Exception":"ValueError","Message":"The arguments array must contain 2 items, 1 given",
"Code":0,"
Trace":[
  {"file":"/var/www/html/lib/private/L10N/L10NString.php",
   "line":88,"function":"vsprintf",
   "args":["%s Benutzer gefunden|%s Benutzer gefunden",["20"]]},
   ...

Steps to reproduce

  1. Install ldap app and configure
  2. Set language to German
  3. Press the "check settings and get user count" button

Expected behavior

User count shown and no exception thrown

Installation method

Official Docker image

Operating system

Other

PHP engine version

No response

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 22.2.3 to 22.2.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • [ ] Default user-backend (database)
  • [X] LDAP/ Active Directory
  • [ ] SSO - SAML
  • [ ] Other

Configuration report

No response

List of activated Apps

- accessibility: 1.9.0
  - activity: 2.15.0
  - bruteforcesettings: 2.4.0
  - calendar: 3.4.2
  - circles: 23.1.2
  - cloud_federation_api: 1.6.0
  - collectives: 1.4.2
  - contacts: 4.2.0
  - contactsinteraction: 1.4.0
  - dashboard: 7.3.0
  - dav: 1.21.0
  - federatedfilesharing: 1.13.0
  - federation: 1.13.0
  - files: 1.18.0
  - files_pdfviewer: 2.4.0
  - files_rightclick: 1.2.0
  - files_sharing: 1.15.0
  - files_trashbin: 1.13.0
  - files_versions: 1.16.0
  - files_videoplayer: 1.12.0
  - forms: 2.5.1
  - groupfolders: 11.1.5
  - logreader: 2.8.0
  - lookup_server_connector: 1.11.0
  - notifications: 2.11.1
  - oauth2: 1.11.0
  - password_policy: 1.13.0
  - photos: 1.5.0
  - privacy: 1.7.0
  - provisioning_api: 1.13.0
  - recommendations: 1.2.0
  - serverinfo: 1.13.0
  - settings: 1.5.0
  - sharebymail: 1.13.0
  - survey_client: 1.11.0
  - systemtags: 1.13.0
  - tasks: 0.14.4
  - text: 3.4.1
  - theming: 1.14.0
  - twofactor_backupcodes: 1.12.0
  - updatenotification: 1.13.0
  - user_ldap: 1.13.1
  - viewer: 1.7.0
  - weather_status: 1.3.0
  - workflowengine: 2.5.0
Disabled:
  - admin_audit
  - comments: 1.13.0
  - encryption
  - files_external
  - firstrunwizard: 2.9.0
  - nextcloud_announcements: 1.9.0
  - support: 1.3.0
  - user_sql: 4.7.1
  - user_status: 1.0.1

Nextcloud Signing status

No response

Nextcloud Logs

{"reqId":"aQpeFrbyhNdzuuuaZ5d4","level":3,"time":"2022-08-10T08:41:07+00:00","remoteAddr":"95.90.158.23","user":"AdminFisch","app":"index","method":"POST","url":"/apps/user_ldap/ajax/wizard.php","message":"The arguments array must contain 2 items, 1 given","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0","version":"23.0.7.2","exception":{"Exception":"ValueError","Message":"The arguments array must contain 2 items, 1 given","Code":0,"Trace":[{"file":"/var/www/html/lib/private/L10N/L10NString.php","line":88,"function":"vsprintf","args":["%s Benutzer gefunden|%s Benutzer gefunden",["20"]]},{"file":"/var/www/html/lib/private/L10N/L10N.php","line":127,"function":"__toString","class":"OC\\L10N\\L10NString","type":"->","args":[]},{"file":"/var/www/html/lib/private/L10N/LazyL10N.php","line":56,"function":"n","class":"OC\\L10N\\L10N","type":"->","args":["%s user found","%s users found",20,["20"]]},{"file":"/var/www/html/apps/user_ldap/lib/Wizard.php","line":177,"function":"n","class":"OC\\L10N\\LazyL10N","type":"->","args":["%s user found","%s users found",20,["20"]]},{"file":"/var/www/html/apps/user_ldap/ajax/wizard.php","line":96,"function":"countUsers","class":"OCA\\User_LDAP\\Wizard","type":"->","args":[]},{"file":"/var/www/html/lib/private/Route/Route.php","line":155,"args":["/var/www/html/apps/user_ldap/ajax/wizard.php"],"function":"require_once"},{"function":"OC\\Route\\{closure}","class":"OC\\Route\\Route","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":310,"function":"call_user_func","args":[{"__class__":"Closure"},["user_ldap_ajax_wizard"]]},{"file":"/var/www/html/lib/base.php","line":1008,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/user_ldap/ajax/wizard.php"]},{"file":"/var/www/html/index.php","line":36,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/var/www/html/lib/private/L10N/L10NString.php","Line":88,"CustomMessage":"--"}}

Additional info

NC version 23.0.7

susnux avatar Aug 10 '22 10:08 susnux

Still present on NC 24.0.4. The German translation of the LDAP plugin is the culprit. Everything works as expected when the language is set to English.

robertmx avatar Sep 08 '22 16:09 robertmx

That actually breaks the whole interface. Besides the user and group counts not working, it is not possible to test a given user name.

robertmx avatar Sep 08 '22 16:09 robertmx