server icon indicating copy to clipboard operation
server copied to clipboard

Remake profile picture saving with Vue

Open Pytal opened this issue 3 years ago • 0 comments

Remake profile picture saving with Vue for accessibility purposes

Legacy code is removed

  • OC.Settings.updateAvatar is dropped and is an API break but low impact as it is unused
  • Drop deprecated @nextcloud/jcrop dependency

Screenshots

Before After
image image
image image

Pytal avatar Jul 30 '22 00:07 Pytal

The cropper part was put inline in the page to be inline edited like other fields but we can put it back in a modal like before if desired @jancborchardt @nimishavijay?

Pytal avatar Aug 27 '22 00:08 Pytal

The cropper part was put inline in the page to be inline edited like other fields but we can put it back in a modal like before if desired @jancborchardt @nimishavijay?

Not sure we gain that much to be in a modal? Maybe just a little more focus? I think it's fine both ways, so if it's technically easier inline, so be it. But since this is design let's still wait for the design team confirmation :)

skjnldsv avatar Aug 27 '22 15:08 skjnldsv

Rebased

Not sure we gain that much to be in a modal? Maybe just a little more focus? I think it's fine both ways, so if it's technically easier inline, so be it.

Not necessarily technically easier just that editing stuff inline in the same place that it's displayed seems more intuitive, other than that don't have a strong leaning either way

Pytal avatar Sep 01 '22 01:09 Pytal

Integration is failing https://drone.nextcloud.com/nextcloud/server/22585/22/3

skjnldsv avatar Sep 01 '22 06:09 skjnldsv

Rebased with fixed integration tests

Pytal avatar Sep 01 '22 18:09 Pytal

If there are any further changes we should make @jancborchardt @nimishavijay just ping here

Pytal avatar Sep 02 '22 04:09 Pytal