server icon indicating copy to clipboard operation
server copied to clipboard

Remake phone number property saving with Vue

Open Pytal opened this issue 3 years ago • 1 comments

Remake phone number property saving with Vue for accessibility purposes

The https://github.com/catamphetamine/libphonenumber-js library is used here to mirror our backend validation https://github.com/giggsey/libphonenumber-for-php https://github.com/nextcloud/server/blob/952acd4d276b3190d23e0597c5e01b1dfc4d72bc/lib/private/Accounts/AccountManager.php#L188 as closely as possible

Pytal avatar Jul 21 '22 20:07 Pytal

Possible performance regression detected

Show Output
1 queries added

= /remote.php/dav/files/test
≠ /remote.php/dav/files/test/test.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/many_files with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

github-actions[bot] avatar Jul 26 '22 01:07 github-actions[bot]