server icon indicating copy to clipboard operation
server copied to clipboard

Remake Twitter handle saving with Vue

Open Pytal opened this issue 3 years ago • 5 comments

Remake Twitter handle saving with Vue for accessibility purposes alongside preparations for allowing simple replacement of other account property sections with Vue

Incorporates improvements to accessibility from the https://github.com/nextcloud/nextcloud-vue library over the legacy PHP implementation

Deprecation

The lookupServerUploadEnabled block https://github.com/nextcloud/server/blob/16b06dd75889bef318881a4783cff03aaeb971d9/apps/settings/templates/settings/personal/personal.info.php#L208-L235 is deprecated and therefore not brought over as it is only displayed under the condition that your Twitter handle is set and the scope is public which is never the case as the public scope was deprecated in 21.0.1 https://github.com/nextcloud/server/blob/16b06dd75889bef318881a4783cff03aaeb971d9/lib/public/Accounts/IAccountManager.php#L86-L91

Requires

  • [x] https://github.com/nextcloud/server/pull/33206

Pytal avatar Jul 13 '22 00:07 Pytal

Possible performance regression detected

Show Output
1 queries added

= /remote.php/dav/files/test
≠ /remote.php/dav/files/test/test.txt with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/many_files with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

github-actions[bot] avatar Jul 14 '22 01:07 github-actions[bot]

Keeping as draft pending merge of

  • [x] https://github.com/nextcloud/server/pull/33206

Pytal avatar Jul 15 '22 20:07 Pytal

Possible performance regression detected

Show Output
1 queries added

≠ /remote.php/dav/files/test with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/test.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

github-actions[bot] avatar Jul 15 '22 20:07 github-actions[bot]

Possible performance regression detected

Show Output
1 queries added

≠ /remote.php/dav/files/test with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/test.txt
≠ /remote.php/dav/files/test/many_files with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

github-actions[bot] avatar Jul 26 '22 00:07 github-actions[bot]

Rebased and review-ready

Pytal avatar Aug 09 '22 03:08 Pytal

@Pytal this PR seems to contain a lot more changes than just the Twitter handle, in case it's not a mistake, please adjust the PR title and description

PVince81 avatar Aug 10 '22 20:08 PVince81

@Pytal this PR seems to contain a lot more changes than just the Twitter handle, in case it's not a mistake, please adjust the PR title and description

Title updated, description already adjusted and commits already split between modularization and Twitter section

Pytal avatar Aug 11 '22 01:08 Pytal

@Pytal rebase needed and also a second review

PVince81 avatar Aug 25 '22 15:08 PVince81