Fixed 'overwritewebroot' not work with 'overwritecondaddr'.

Open takahiro-blab opened this issue 3 years ago • 1 comments

Client ip address must be passed to fakeRequest (OC\AppFramework\Http\Request). Since this is not case, 'overwritewebroot' under 'overwritecondaddr' does not work through OC\AppFramework\HTTP\Request#getScriptName and its isOverwriteCondition.

In order for 'overwritecondaddr' to work properly, PR #30654 must be also merged.

Feb 04 '22 06:02 takahiro-blab

~~closing as dup of https://github.com/nextcloud/server/issues/6914~~ sorry, mistook it as an issue.

Feb 09 '22 09:02 blizzz

rebased and fixed conflicts

May 16 '23 09:05 szaimen

CI failure unrelated

May 16 '23 21:05 szaimen

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

May 16 '23 21:05 welcome[bot]