server icon indicating copy to clipboard operation
server copied to clipboard

Change `Sabre\DAV\Exception\InsufficientStorage` (quota reached) log level from fatal to warning or info

Open alx-tuilmenau opened this issue 5 years ago • 10 comments

Feature Request:

Is there a possibility to change the logging of "Sabre\DAV\Exception\InsufficientStorage: Insufficient space in ..." from fatal to warning or info, if only the quota for a user is full, so the logging of these messages can be turned off without missing real errors ?

The message is logged, if a user tries to upload further files via Desktop Client, if his quota is full (and a lot of times, because the client is still trying every file...)

alx-tuilmenau avatar Apr 16 '20 09:04 alx-tuilmenau

Is this Issue still valid in NC21.0.2? If not, please close this issue. Thanks! :)

szaimen avatar Jun 08 '21 11:06 szaimen

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

ghost avatar Jul 08 '21 11:07 ghost

Sorry, I missed the comment. Its still present in 21.0.3. The Message is only logged for Uploads via Client / WebDAV, uploading via Web gives the user a message and no message in Log.

alx-tuilmenau avatar Jul 08 '21 11:07 alx-tuilmenau

cc @nextcloud/server-triage is this request feasible?

Some pointers: https://github.com/nextcloud/3rdparty/blob/master/sabre/dav/lib/DAV/Exception/InsufficientStorage.php https://github.com/nextcloud/server/blob/81722d5655c96ab192918b0e088da59a20c51dff/apps/dav/lib/Connector/Sabre/QuotaPlugin.php#L175

szaimen avatar Jul 14 '21 21:07 szaimen

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

ghost avatar Aug 13 '21 21:08 ghost

This is still present in current NC 24.0.6.

ThomasCr avatar Nov 02 '22 10:11 ThomasCr

Still present in NC 26.0.5 Should I re-open an issue ?

quentinDupont avatar Sep 12 '23 06:09 quentinDupont

Yes, it's still present. Still got tons of log entries if someone's client is trying to sync with full quota.

alx-tuilmenau avatar Sep 12 '23 06:09 alx-tuilmenau

Interesting enough I have the issue in nextcloud 27.1.9 with the desktopclient version 3.13.0 Quota was reached one Than i extended the quota I can upload files via webbrowser but the client isnt syncing there are still 140 GB of space available for the root partition, groupfolders:list tells me that Quota | Size are 38/16 GB Its on a local machine Ubuntu 22 PHP 8.1.2 -MariaDB 10.6.16

moboter avatar May 29 '24 11:05 moboter

I also got still this Message with 28.0.6:

Error Message in log { "reqId": "iqPstuYSWWfOWp6vWUmt", "level": 3, "time": "2024-05-29T10:02:25+00:00", "remoteAddr": "xxx", "user": "kxxx", "app": "webdav", "method": "MOVE", "url": "/remote.php/dav/uploads/xxx/2114599060/.file", "message": "Insufficient space in xxx, 326966101716 required, 105978238676 available", "userAgent": "Mozilla/5.0 (Windows) mirall/3.4.1stable-Win64 (build 20211221) (Nextcloud, windows-10.0.22631 ClientArchitecture: x86_64 OsArchitecture: x86_64)", "version": "28.0.6.1", "exception": { "Exception": "Sabre\\DAV\\Exception\\InsufficientStorage", "Message": "Insufficient space in /xxx required, 105978238676 available", "Code": 0, "Trace": [ { "file": "/data/nextcloud_a3/apps/dav/lib/Connector/Sabre/QuotaPlugin.php", "line": 142, "function": "checkQuota", "class": "OCA\\DAV\\Connector\\Sabre\\QuotaPlugin", "type": "->" }, { "file": "/data/nextcloud_a3/3rdparty/sabre/event/lib/WildcardEmitterTrait.php", "line": 89, "function": "beforeMove", "class": "OCA\\DAV\\Connector\\Sabre\\QuotaPlugin", "type": "->" }, { "file": "/data/nextcloud_a3/3rdparty/sabre/dav/lib/DAV/CorePlugin.php", "line": 603, "function": "emit", "class": "Sabre\\DAV\\Server", "type": "->" }, { "file": "/data/nextcloud_a3/3rdparty/sabre/event/lib/WildcardEmitterTrait.php", "line": 89, "function": "httpMove", "class": "Sabre\\DAV\\CorePlugin", "type": "->" }, { "file": "/data/nextcloud_a3/3rdparty/sabre/dav/lib/DAV/Server.php", "line": 472, "function": "emit", "class": "Sabre\\DAV\\Server", "type": "->" }, { "file": "/data/nextcloud_a3/3rdparty/sabre/dav/lib/DAV/Server.php", "line": 253, "function": "invokeMethod", "class": "Sabre\\DAV\\Server", "type": "->" }, { "file": "/data/nextcloud_a3/3rdparty/sabre/dav/lib/DAV/Server.php", "line": 321, "function": "start", "class": "Sabre\\DAV\\Server", "type": "->" }, { "file": "/data/nextcloud_a3/apps/dav/lib/Server.php", "line": 373, "function": "exec", "class": "Sabre\\DAV\\Server", "type": "->" }, { "file": "/data/nextcloud_a3/apps/dav/appinfo/v2/remote.php", "line": 35, "function": "exec", "class": "OCA\\DAV\\Server", "type": "->" }, { "file": "/data/nextcloud_a3/remote.php", "line": 172, "args": [ "/data/nextcloud_a3/apps/dav/appinfo/v2/remote.php" ], "function": "require_once" } ], "File": "/data/nextcloud_a3/apps/dav/lib/Connector/Sabre/QuotaPlugin.php", "Line": 216, "message": "Insufficient space in xxx, 326966101716 required, 105978238676 available", "exception": [], "CustomMessage": "Insufficient space in /xxx, 326966101716 required, 105978238676 available" }, "id": "66571b0184b4b" }

alx-tuilmenau avatar May 29 '24 12:05 alx-tuilmenau

Can this please be looked into. Displaying errors to admins that aren't relevant can cause notification/alert fatigue and they can begin to ignore looking at the logs because it's "just noise".

Justinzobel avatar Dec 06 '24 02:12 Justinzobel

Optionally split this into two functions, one for user-quota not enough storage and another for server not enough storage.

As the second one is critical information to the server administrator. The first is irrelevant to the administrator and only relevant to the user.

Justinzobel avatar Feb 25 '25 00:02 Justinzobel