Reset password is truncated

[JorisBodin]

Hello, In french is truncated

"Réinitialiser le mot de passe"

On Google Chrome Version 79.0.3945.117 and macos catalina

[bvaughan26]

The problem is in the mobile Android app. I cannot find any place to update it

Le problème est dans l'application mobile Android. Je ne trouve aucun endroit pour le mettre à jour

From: Joris Bodin [email protected] Sent: Thursday, January 16, 2020 9:58 AM To: nextcloud/server [email protected] Cc: Subscribed [email protected] Subject: [nextcloud/server] Reset password is truncated (#18937)

Hello, In french is truncated [image]https://user-images.githubusercontent.com/2796439/72545549-7c947300-3889-11ea-8844-d30ef29e3b55.png

"Réinitialiser le mot de passe"

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/nextcloud/server/issues/18937?email_source=notifications&email_token=AOGTHPFSECOINEJXX2ILLR3Q6CGY5A5CNFSM4KHXJRH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IGWTGMA, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOGTHPDPZQ4HUMANAJHRATTQ6CGY5ANCNFSM4KHXJRHQ.

[JorisBodin]

@bvaughan26 is not in android app Is on web server

[kesselb]

Is it possible to find a shorter phrase? If yes the translations are here: https://www.transifex.com/nextcloud/nextcloud If no we have to ask one of the design people ;)

[JorisBodin]

We can change just to "Réinitialiser" In english is "Reset password" to just "Reset" But it would have to be changed for all languages, I think.

[kesselb]

core/l10n$ grep -r "\"Password reset\"" .
./nl.js:    "Password reset" : "Herstel wachtwoord",
./vi.js:    "Password reset" : "Đặt lại mật khẩu",
./es_HN.json:    "Password reset" : "Restablecer contraseña",
./ru.json:    "Password reset" : "Сброс пароля",
./ka_GE.js:    "Password reset" : "პაროლის აღდგენა",
./sv.json:    "Password reset" : "Lösenordsåterställning",
./it.json:    "Password reset" : "Ripristino password",
./hu.json:    "Password reset" : "Jelszó visszaállítás",
./cs.json:    "Password reset" : "Reset hesla",
./it.js:    "Password reset" : "Ripristino password",
./es_CL.json:    "Password reset" : "Restablecer contraseña",
./es_DO.js:    "Password reset" : "Restablecer contraseña",
./sr.js:    "Password reset" : "Ресетовање лозинке",
./es_HN.js:    "Password reset" : "Restablecer contraseña",
./nb.json:    "Password reset" : "Tilbakestilling av passord",
./en_GB.json:    "Password reset" : "Password reset",
./fa.js:    "Password reset" : "تنظیم مجدد رمز عبور",
./zh_CN.js:    "Password reset" : "重置密码",
./es_CL.js:    "Password reset" : "Restablecer contraseña",
./es_NI.json:    "Password reset" : "Restablecer contraseña",
./ru.js:    "Password reset" : "Сброс пароля",
./es_MX.js:    "Password reset" : "Restablecer contraseña",
./lv.js:    "Password reset" : "Parole atiestatīta",
./pl.js:    "Password reset" : "Zresetowanie hasła",
./sk.js:    "Password reset" : "Obnovenie hesla",
./nl.json:    "Password reset" : "Herstel wachtwoord",
./es_PY.json:    "Password reset" : "Restablecer contraseña",
./vi.json:    "Password reset" : "Đặt lại mật khẩu",
./eo.js:    "Password reset" : "Restarigi pasvorton",
./tr.json:    "Password reset" : "Parolamı Sıfırla",
./ja.json:    "Password reset" : "パスワードのリセット",
./es_SV.js:    "Password reset" : "Restablecer contraseña",
./es_CO.js:    "Password reset" : "Restablecer contraseña",
./bg.json:    "Password reset" : "Възстановяване на парола",
./es_CO.json:    "Password reset" : "Restablecer contraseña",
./de.js:    "Password reset" : "Passwort zurücksetzen",
./es.json:    "Password reset" : "Restablecer contraseña",
./sq.json:    "Password reset" : "Fjalkalimi u rivendos",
./lt_LT.json:    "Password reset" : "Slaptažodžio atstatymas",
./es_PA.json:    "Password reset" : "Restablecer contraseña",
./sl.json:    "Password reset" : "Ponastavitev gesla",
./fr.js:    "Password reset" : "Réinitialiser le mot de passe",
./es_PR.json:    "Password reset" : "Restablecer contraseña",
./cs.js:    "Password reset" : "Reset hesla",
./fa.json:    "Password reset" : "تنظیم مجدد رمز عبور",
./af.json:    "Password reset" : "Wagwoord herstel",
./bg.js:    "Password reset" : "Възстановяване на парола",
./es_EC.js:    "Password reset" : "Restablecer contraseña",
./ast.js:    "Password reset" : "Reaniciu de contrseña",
./gl.js:    "Password reset" : "Restabelecer o contrasinal",
./eu.js:    "Password reset" : "Pasahitza berrezarri",
./de_DE.json:    "Password reset" : "Passwort zurücksetzen",
./pt_PT.json:    "Password reset" : "Reposição da senha",
./es_CR.json:    "Password reset" : "Restablecer contraseña",
./lt_LT.js:    "Password reset" : "Slaptažodžio atstatymas",
./et_EE.json:    "Password reset" : "Parooli taastamine ",
./es_SV.json:    "Password reset" : "Restablecer contraseña",
./da.js:    "Password reset" : "Nulstil adgangskode",
./es_419.json:    "Password reset" : "Restablecer contraseña",
./eo.json:    "Password reset" : "Restarigi pasvorton",
./pt_PT.js:    "Password reset" : "Reposição da senha",
./zh_CN.json:    "Password reset" : "重置密码",
./he.js:    "Password reset" : "איפוס סיסמה",
./sk.json:    "Password reset" : "Obnovenie hesla",
./es_DO.json:    "Password reset" : "Restablecer contraseña",
./lv.json:    "Password reset" : "Parole atiestatīta",
./es_PR.js:    "Password reset" : "Restablecer contraseña",
./es_CR.js:    "Password reset" : "Restablecer contraseña",
./ko.json:    "Password reset" : "암호 재설정",
./de.json:    "Password reset" : "Passwort zurücksetzen",
./es_GT.json:    "Password reset" : "Restablecer contraseña",
./hr.json:    "Password reset" : "Resetiranje zaporke",
./pt_BR.json:    "Password reset" : "Redefinir a senha",
./uk.js:    "Password reset" : "Скидання паролю",
./fi.json:    "Password reset" : "Salasanan palautus",
./es_UY.js:    "Password reset" : "Restablecer contraseña",
./eu.json:    "Password reset" : "Pasahitza berrezarri",
./tr.js:    "Password reset" : "Parolamı Sıfırla",
./en_GB.js:    "Password reset" : "Password reset",
./es_419.js:    "Password reset" : "Restablecer contraseña",
./af.js:    "Password reset" : "Wagwoord herstel",
./es_PE.js:    "Password reset" : "Restablecer contraseña",
./ca.js:    "Password reset" : "Canvi de contrasenya",
./ka_GE.json:    "Password reset" : "პაროლის აღდგენა",
./ro.js:    "Password reset" : "Resetare parolă",
./de_DE.js:    "Password reset" : "Passwort zurücksetzen",
./es_PA.js:    "Password reset" : "Restablecer contraseña",
./sr.json:    "Password reset" : "Ресетовање лозинке",
./sq.js:    "Password reset" : "Fjalkalimi u rivendos",
./ro.json:    "Password reset" : "Resetare parolă",
./fr.json:    "Password reset" : "Réinitialiser le mot de passe",
./hr.js:    "Password reset" : "Resetiranje zaporke",
./zh_TW.json:    "Password reset" : "密碼重設",
./es_MX.json:    "Password reset" : "Restablecer contraseña",
./el.json:    "Password reset" : "Επαναφορά συνθηματικού",
./es_UY.json:    "Password reset" : "Restablecer contraseña",
./mk.js:    "Password reset" : "Ресетирај лозинка",
./es_GT.js:    "Password reset" : "Restablecer contraseña",
./ca.json:    "Password reset" : "Canvi de contrasenya",
./el.js:    "Password reset" : "Επαναφορά συνθηματικού",
./he.json:    "Password reset" : "איפוס סיסמה",
./es_NI.js:    "Password reset" : "Restablecer contraseña",
./ja.js:    "Password reset" : "パスワードのリセット",
./is.json:    "Password reset" : "Endurstilling lykilorðs",
./es_PY.js:    "Password reset" : "Restablecer contraseña",
./et_EE.js:    "Password reset" : "Parooli taastamine ",
./is.js:    "Password reset" : "Endurstilling lykilorðs",
./ar.json:    "Password reset" : "إعادة تعيين كلمة مرور",
./pl.json:    "Password reset" : "Zresetowanie hasła",
./sv.js:    "Password reset" : "Lösenordsåterställning",
./nb.js:    "Password reset" : "Tilbakestilling av passord",
./mk.json:    "Password reset" : "Ресетирај лозинка",
./ar.js:    "Password reset" : "إعادة تعيين كلمة مرور",
./gl.json:    "Password reset" : "Restabelecer o contrasinal",
./es_AR.json:    "Password reset" : "Restablecer contraseña",
./sl.js:    "Password reset" : "Ponastavitev gesla",
./zh_TW.js:    "Password reset" : "密碼重設",
./da.json:    "Password reset" : "Nulstil adgangskode",
./pt_BR.js:    "Password reset" : "Redefinir a senha",
./es_PE.json:    "Password reset" : "Restablecer contraseña",
./uk.json:    "Password reset" : "Скидання паролю",
./ast.json:    "Password reset" : "Reaniciu de contrseña",
./hu.js:    "Password reset" : "Jelszó visszaállítás",
./es_AR.js:    "Password reset" : "Restablecer contraseña",
./es_EC.json:    "Password reset" : "Restablecer contraseña",
./es.js:    "Password reset" : "Restablecer contraseña",
./fi.js:    "Password reset" : "Salasanan palautus",
./ko.js:    "Password reset" : "암호 재설정",

But it would have to be changed for all languages

Yep. Probably easier to make the text smaller. The designers will figure something out ;)

cc @nextcloud/designers

[Dennis1993]

In the german translation it is ok but the arrow is not in the button:

If I write any text in the button the text will be truncated correctly:

[Dennis1993]

The problem is the width of the wrapper. In the login form it is not so wide. Here the width is 700px

[kesselb]

@Dennis1993 that's a different issue.

[szaimen]

Is this still the case on nc23.0.2?

[samarthasthan]

@JorisBodin Hey can I know about problem in more detail ?

[JorisBodin]

The text should not be truncated, the font size should be dynamically reduced or the button size should be increased.

[RyanAveritt]

Hello, I am a first-time contributor and am interested in taking on this task if it's still available.

[RyanAveritt]

@JorisBodin wanted to check up on this, sorry if this isn't a typical practice.

[joshtrichards]

@RyanAveritt If the still can reproduce the existing behavior and the Issue is still open, have at it. No one is stopping you. Give it a shot. :)

[jancborchardt]

@marcoambrosini @szaimen a simple correct ellipsize with the correct icon placement would be enough here. :)

The text should not be truncated, the font size should be dynamically reduced or the button size should be increased.

If this is possible we can also do it, but currently we don’t have a precedent for this.

[Dennis1993]

Why we replace the text with a simple arrow icon? It's clear for what the button stand for in this case. So my idea is to remove the text and set the button in the input as an arrow like this: quick edit in photoshop

Is that a way for us or has someone a problem with it? :)

[marcoambrosini]

@jancborchardt I also think we shouldn't truncate the text. There's plenty of space on the page to make the button as wide as it needs to be, don't you think?
@Dennis1993 same thing. We have plenty of space for a labelled button, so we should use it. It improves user experience as it expresses clearly what's going to happen.

[szaimen]

Hm... looks good on 28: So close?

[tcitworld]

Yup, seems fine