server icon indicating copy to clipboard operation
server copied to clipboard

Add template renderas empty

Open rullzer opened this issue 7 years ago • 5 comments

Richdocuments renders all their templates as empty. This is done because we embed the view in an iframe and we do not need the top bar etc etc.

This works because the old code never checks the render as value as being one of the valid ones.

I'd vote to make this an official mode. And then also make sure that we kill javascript that doesn't belong there (for example the search stuff).

CC: @nickvergessen @MorrisJobke

rullzer avatar Jul 07 '18 19:07 rullzer

GitMate.io thinks possibly related issues are https://github.com/nextcloud/server/issues/5534 (Empty trash), https://github.com/nextcloud/server/pull/10128 (Add locale to templates), https://github.com/nextcloud/server/issues/9529 (Template file), https://github.com/nextcloud/server/issues/74 (Add Automatic Tagging), and https://github.com/nextcloud/server/issues/6553 (Add public page template for apps).

nextcloud-bot avatar Jul 07 '18 19:07 nextcloud-bot

So then there are 3? '', 'blank' and 'empty' ?

I'd vote for "add constants and unify the usage", because f#$k magic strings :sunglasses:

nickvergessen avatar Jul 09 '18 09:07 nickvergessen

And btw blank and empty are used since 4+ years: https://github.com/nextcloud/server/blob/0655df09d6cfcec1084680a6ef9082422a1ca578/lib/public/AppFramework/Http/TemplateResponse.php#L149

nickvergessen avatar Jul 09 '18 09:07 nickvergessen

Yes lets add them as constants!

Also if they are there already we should exclude some js loading on blank and empty etc.

rullzer avatar Jul 09 '18 14:07 rullzer

I suppose this issue is still valid? If not, please close this issue!

szaimen avatar May 26 '21 09:05 szaimen