richdocuments icon indicating copy to clipboard operation
richdocuments copied to clipboard

Implement direct editing API

Open juliusknorr opened this issue 5 years ago • 5 comments

https://github.com/nextcloud/server/pull/17625

  • Make sure that template creation is properly handled with the new approach from https://github.com/nextcloud/richdocuments/pull/1377

juliusknorr avatar Dec 02 '19 12:12 juliusknorr

From previous discussions, we need to verify the implementation on Desktop, Android and iOS, while desktop has higher probability to work out of the box as the others currently have existing special logic for office documents with Collabora.

juliusknorr avatar Aug 24 '22 16:08 juliusknorr

When you need help from our side, we are happy to help. We can also have a short call between both of us to coordinate it. Right now I am unsure what to check :)

tobiasKaminsky avatar Aug 25 '22 13:08 tobiasKaminsky

When you need help from our side, we are happy to help. We can also have a short call between both of us to coordinate it. Right now I am unsure what to check :)

Sorry, forgot to push the PR! ;) https://github.com/nextcloud/richdocuments/pull/2405

I have tried testing it on Android but I cannot open the files (gets stuck on loading), however the endpoint seems to work when entered manually through the browser though. Also I believe the Android app has hardcoded support for creating office files (when Nextcloud office is installed).

Raudius avatar Aug 25 '22 13:08 Raudius

Android/clients need to switch to new endpoint then, I think. So I will test to switch entire Collabora usage from richdocuments endpoint to directEditing, same like with Text, right?

tobiasKaminsky avatar Aug 25 '22 14:08 tobiasKaminsky

  • We need to wait for clients to be released to push this as otherwise there might be duplicate direct editing in the clients with the old and new approach

juliusknorr avatar Oct 11 '22 08:10 juliusknorr

This will be the shared library that also can be used to generate documentation on the message passing between clients and the different editor implementations:https://github.com/nextcloud/nextcloud-directediting

juliusknorr avatar Nov 16 '22 11:11 juliusknorr