refactor: untangle Node|ICacheEntry parameter in shouldWatermark

Open blizzz opened this issue 3 months ago • 0 comments

Addition to #5058

Results in split methods as we do not have nice overloading in PHP. But simplifies parameters when calling them, while implementation is being hidden yet simplified as it does not have to deal with different objects but a few primitive types.

Additionally has a small fix in the tests (provides file id as int).

Actually I am a bit torn about this one. What do you find better maintainable?

Oct 07 '25 18:10 blizzz