richdocuments icon indicating copy to clipboard operation
richdocuments copied to clipboard

Inform user that file insertion failed

Open eszkadev opened this issue 9 months ago • 2 comments

Is your feature request related to a problem? Please describe. I heared many complaints from users who didn't manage to insert Image from the NC storage that "nothing happens". It is a problem with using nginx proxy in front of NC what causes request to assests failed. In that case unfortunately there is no visible feedback for user what happened. After investigation it is FilePicker error. Best would be to check request status.

https://github.com/nextcloud/richdocuments/blob/b1f979e3ea9e910f12f84c872f6890467be505e9/src/view/FilesAppIntegration.js#L164

Describe the solution you'd like It would be good to provide message dialog with error visible for user when file insertion failed.

Additional context Related to: https://github.com/nextcloud/richdocuments/issues/4565

eszkadev avatar Mar 11 '25 08:03 eszkadev

Definitely 👍

It is a problem with using nginx proxy in front of NC what causes request to assests failed. In that case unfortunately there is no visible feedback for user what happened. After investigation it is FilePicker error. Best would be to check request status.

I would be curious on more details around that. I've never seen such failures and the api call is rather generic so would be curious why nginx proxy could cause issues there

juliusknorr avatar Mar 11 '25 08:03 juliusknorr

I would be curious on more details around that. I've never seen such failures and the api call is rather generic so would be curious why nginx proxy could cause issues there

Such an example happened: a badly configured reverse-proxy in front of nextcloud redirected requests to /apps/richdocuments/assets to apps/richdocuments/assets/ with a 301 and changing the request from POST to GET even. The result of the request, with an error in Collabora Online following, while it could be detected more clearly earlier.

meven avatar Mar 11 '25 09:03 meven