richdocuments icon indicating copy to clipboard operation
richdocuments copied to clipboard

Theme logo not appearing, top left navigation

Open nooblag opened this issue 1 year ago • 9 comments

Describe the bug A theme logo no longer appears in Nextcloud Office/Collabora, top left navigation.

To Reproduce Steps to reproduce the behavior:

  1. Open a document

Expected behavior Collabora pulls logo from Nextcloud theme as usual/before.

Actual behavior Nextcloud logo appears. Theme logo is ignored.

Screenshots Screenshot from 2024-08-21 05-52-38

Client details:

  • OS: All OSes
  • Browser All browsers

Server details

Operating system: Ubuntu 22.04.4 LTS

Web server: nginx version: nginx/1.18.0 (Ubuntu)

Database: psql (PostgreSQL) 14.13 (Ubuntu 14.13-0ubuntu0.22.04.1)

PHP version: PHP 8.2.22 (cli) (built: Aug 2 2024 15:36:02) (NTS)

Nextcloud version: 29.0.5

Version of the richdocuments app 8.4.4

Version of Collabora Online COOLWSD version: 24.04.6.2 (git hash: 4fd2181 (E)) LOKit version: Collabora Office 24.04.6.2 (git hash: 47680e0)

Configuration of the richdocuments app

{
    "apps": {
        "richdocuments": {
            "wopi_allowlist": "127.0.0.1, ***redacted_IP***",
            "doc_format": "ooxml",
            "public_wopi_url": "https:\/\/***redacted_URL***",
            "external_apps": "Public Access:***redacted_key***,",
            "types": "prevent_group_restriction",
            "canonical_webroot": "",
            "wopi_url": "https:\/\/***redacted_URL***",
            "disable_certificate_verification": "",
            "installed_version": "8.4.4",
            "enabled": "yes"
        }
    }
}

nooblag avatar Aug 20 '24 20:08 nooblag

Was fixed with https://github.com/nextcloud/richdocuments/pull/3925

juliusknorr avatar Aug 21 '24 08:08 juliusknorr

Regression on this?

Theme logo again not appearing with:

COOLWSD version: 24.04.10.2(git hash: a4b67a7664 (E))
LOKit version: Collabora Office 24.04.10.2(git hash: 9d0c2a6)
Served by: Ubuntu 22.04.5 LTS

Nextcloud 29.0.10

nooblag avatar Dec 11 '24 15:12 nooblag

@nooblag Are you using the most recent version of Nextcloud Office for Nextcloud 29? It should be richdocuments v8.4.9.

elzody avatar Dec 12 '24 19:12 elzody

Thank you for getting back. Yes, running Nextcloud Office (richdocuments) version 8.4.9.

nooblag avatar Dec 12 '24 22:12 nooblag

Exact same issue here, the logo suddenly became the default one after upgrading to 24.04.10.2. The nextcloud-version does not matter, it happens with Nextcloud Hub 8 (29.0.10) and older versions. Richdocuments is on Version 8.4.9.

wico avatar Dec 17 '24 08:12 wico

Unfortunately, I can confirm this now. Will be considered a regression I guess, and I will have a look how to fix it.

elzody avatar Dec 17 '24 22:12 elzody

Not sure how, but some kind of test case for this would be great to catch further regressions early next time.

juliusknorr avatar Dec 20 '24 08:12 juliusknorr

Maybe #4104 introduced this regression?

joshtrichards avatar May 04 '25 16:05 joshtrichards

I think this has been fixed again, I can no longer reproduce

juliusknorr avatar Jun 04 '25 14:06 juliusknorr

New design adjustment now removed the logo and replaced it with the file type icon

juliusknorr avatar Oct 14 '25 21:10 juliusknorr