richdocuments icon indicating copy to clipboard operation
richdocuments copied to clipboard

richdocuments: add host_session_id parameter

Open hcvcastro opened this issue 1 year ago • 3 comments

  • Resolves: #
  • Target version: main

Summary

TODO

  • [ ] ...

Checklist

  • [ ] Code is properly formatted
  • [ ] Sign-off message is added to all commits
  • [ ] Documentation (manuals or wiki) has been updated or is not required

hcvcastro avatar Jun 13 '24 22:06 hcvcastro

Can you provide some context on what this is used?

In addition you can already get the richdocuments version in the frontend code through the capabilities so no backend changes should be required and please also add it to https://github.com/nextcloud/richdocuments/blob/e9ec3189c92c229475f6430b47e02d6463699c65/src/view/Office.vue#L51

import { getCapabilities } from '../services/capabilities.ts'

getCapabilities().version

juliusknorr avatar Jun 14 '24 08:06 juliusknorr

Thanks, it is mostly to implement Wopi HOST_SESSION_ID, to debugging log purposes and to track wopi host logs for troubleshooting purposes based on a host-specific session identifier

hcvcastro avatar Jun 14 '24 11:06 hcvcastro

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

github-actions[bot] avatar Jun 28 '24 02:06 github-actions[bot]