richdocuments icon indicating copy to clipboard operation
richdocuments copied to clipboard

Exclude MSOffice mime types association if OnlyOffice app is installed

Open proxyconcept opened this issue 2 years ago • 1 comments

Signed-off-by: Grégory Marigot [email protected]

  • Resolves: #2281
  • Target version: master

Summary

The Nextcloud Office app configure the association with all possible office documents mime types. But if we also have the OnlyOffice app, it's not possible to open any document with it...

Collabora and OnlyOffice are both great and it's a common case to want to install both: Collabora for OpenOffice documents and OnlyOffice for MSOffice documents.

This patch is a workaround specific for this case (and because it's not possible to wait for nextcloud/server#8105) : the Nextcloud Office app check if the OnlyOffice app is not installed before adding all the MSOffice mime types.

Checklist

  • [x] Code is properly formatted
  • [x] Sign-off message is added to all commits
  • [ ] Documentation (manuals or wiki) has been updated or is not required

proxyconcept avatar Jul 06 '22 10:07 proxyconcept

If OnlyOffice is installed we should also merge MIMETYPES_MSOFFICE with MIMETYPES_OPTIONAL for the mimetypesNoDefaultOpen capability.

This will allow these mimetypes to be opened with collabora via the context menu.

Raudius avatar Aug 09 '22 08:08 Raudius

@proxyconcept Any news on addressing the review comments?

juliusknorr avatar Jun 09 '23 19:06 juliusknorr

I took over and implemented the suggestion and rebased.

juliusknorr avatar Sep 01 '23 11:09 juliusknorr