richdocuments icon indicating copy to clipboard operation
richdocuments copied to clipboard

Move document params to initial state

Open juliushaertl opened this issue 2 years ago • 1 comments

Avoid building inline javascript in the template to pass over the required metadata for the document opening.

This also fixes an issue where special characters in a filename like It's.odt caused the save as dialog to show double escaped html.

  • [ ] Integration tests currently parse the inline js https://github.com/nextcloud/richdocuments/blob/9bb9661795e69d2a035522affe0913626ae3f02c/tests/features/bootstrap/RichDocumentsContext.php#L200-L213

juliushaertl avatar Jun 03 '22 09:06 juliushaertl

  • [ ] Further app enabled checks calling OCA.AppId or oc_appswebroot https://github.com/nextcloud/richdocuments/pull/2503/files/3428c1f944fa228818309e3c38431268ad92839f#diff-ce81efd19e432a3cd0658d52cccd7c8fbd4b01f4ada9b174f949578fe9af8578

juliushaertl avatar Oct 14 '22 08:10 juliushaertl

Passing run #135 ↗︎

0 24 0 0 Flakiness 0

Details:

Move document params to initial state
Project: Richdocuments Commit: 243cdd9cbd
Status: Passed Duration: 02:38 💡
Started: Feb 2, 2023 8:50 PM Ended: Feb 2, 2023 8:53 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

cypress[bot] avatar Feb 02 '23 20:02 cypress[bot]