recommendations icon indicating copy to clipboard operation
recommendations copied to clipboard

Disable previous and next image on recommendations

Open jakobroehrl opened this issue 5 years ago • 6 comments

The previous and next image in the https://github.com/nextcloud/recommendations and recommendation Dashboard are most of the time wrong

jakobroehrl avatar Oct 25 '20 18:10 jakobroehrl

cc @juliushaertl

skjnldsv avatar Oct 26 '20 08:10 skjnldsv

I'm not sure how we can solve this, as the viewer will just fetch the file listing of the directory that the file is in and use the next/previous image from there. @skjnldsv Is there a way we can block the next/previous navigation when calling OCA.Viewer.open?

juliusknorr avatar Nov 02 '20 10:11 juliusknorr

Ah I guess we could just pass the list of only recommended files to it:

	 * @param {Object[]} [options.list] the list of files as objects (fileinfo) format

juliusknorr avatar Nov 02 '20 10:11 juliusknorr

Yes, if you pass the array containing the single fileInfo, it won't display any other thing :+1: You can also pass the recommended files filesList so next would just go to the second one.

skjnldsv avatar Nov 02 '20 10:11 skjnldsv

@skjnldsv Is there a way we can block the next/previous navigation when calling OCA.Viewer.open?

I've been thinking about adding options for viewer, such as modal-sizes (normal/full) from models, or booleans toggle on viewer.open such as disable fetching etc etc. Don't know if that is worth it though :thinking:

skjnldsv avatar Nov 02 '20 10:11 skjnldsv

Don't know if that is worth it though thinking

I'd say just passing the filelist array is the way to go then. I don't see a reason for another flag yet.

Let me move this over to recommendations.

juliusknorr avatar Nov 02 '20 10:11 juliusknorr