recognize icon indicating copy to clipboard operation
recognize copied to clipboard

required nodejs version is EOL

Open SuperSandro2000 opened this issue 2 years ago • 5 comments

Describe the feature you'd like to request

Right now the admin ui states: Currently supported is Node v14.17 and newer v14 releases. Nodejs 14 is EOL, see https://endoflife.date/nodejs .

Describe the solution you'd like

It should be upgraded to a newer version like 18.

Describe alternatives you've considered

🤷🏼

SuperSandro2000 avatar Oct 01 '23 21:10 SuperSandro2000

I think this is still a problem with 6.0.0. The PHP code still wants to install nodejs 14 https://github.com/nextcloud/recognize/blob/main/lib/Migration/InstallDeps.php#L42-L44 despite the nodejs part already using nodejs 16 https://github.com/nextcloud/recognize/blob/main/package.json#L66.

My distribution removed nodejs 14 and 16 for the next stable release. I have no problem with reverting both and getting them back but I'd imagine other distros will soon have a similar problems were reverting is not always as easy and might demand adding 3rd party sources like nodesource.com which already removed nodejs 14.

SuperSandro2000 avatar Nov 20 '23 11:11 SuperSandro2000

Yes, it still needs to be fixed.

marcelklehr avatar Nov 20 '23 12:11 marcelklehr

@marcelklehr I just wanted to ask about this, and fix it myself, but it seems to be fixed in commit a0ae4ac already? Thx for your work!

espressodriven avatar Apr 27 '24 19:04 espressodriven

That's in no release yet according to git.

SuperSandro2000 avatar Apr 27 '24 22:04 SuperSandro2000

Yes I know that, but what I meant is that I can't help by creating a fix and a pull request for that issue myself, since it is already fixed upstream. @marcelklehr Could you share a preliminary release date for a version which includes this fix?

espressodriven avatar Apr 28 '24 10:04 espressodriven

This will be fixed with v7

marcelklehr avatar May 08 '24 10:05 marcelklehr