polls icon indicating copy to clipboard operation
polls copied to clipboard

I18N/L10n improvements

Open roliverio opened this issue 1 year ago • 2 comments

⚠️ This issue respects the following points: ⚠️

Describe the goal you'd like to achieve

In polls/lib/Service/ActivityService.php:240-242

It is unclear if the string is referring to a person or a share. If it is a share, then there is a grammar issue and it should read:

"You have changed the registration constraints for share {share_name}"

However, it is unknown to me if "{sharee}" (as it is originally written) gets casted to the share name in this context or to the person.

Describe possible solutions

Grammar fix

Additional context

No response

roliverio avatar Jan 07 '24 18:01 roliverio

In this case it is the share name of the public share not connected to a person.

So you suggest to change it to {share_name} right?

dartcafe avatar Feb 14 '24 19:02 dartcafe

Just looking into the code, it is not an easy change, since public polls now have a label or are just called 'Public link'. I think, we have to think about differentiating between public links with and without label.

dartcafe avatar Feb 14 '24 19:02 dartcafe