photos icon indicating copy to clipboard operation
photos copied to clipboard
verified publisher icon nextcloud

Button "Add photos to this album" does not work

Open nicokaiser opened this issue 3 years ago • 4 comments

To Reproduce Steps to reproduce the behavior:

  1. Open Photos app
  2. Navigate to "Folders" view
  3. Open any folder
  4. Click on the "+ Add" button
  5. Click on "+ Add photos to this album" menu item

Nothing happens, and it is unclear what this function should do (add photos to this file folder?)

Expected behavior ?

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: macOS
  • Browser Chrome

Server Nextcloud 25.0.0

nicokaiser avatar Oct 19 '22 16:10 nicokaiser

Works here :shrug:

I will need your browser console log to investigate this issue. Open your console, reload your page and/or do the action leading to this issue and copy/paste the log in this thread.

How to access your browser console (Click to expand)

Chrome

  • Press either CTRL + SHIFT + J to open the “console” tab of the Developer Tools.
  • Alternative method:
    1. Press either CTRL + SHIFT + I or F12 to open the Developer Tools.
    2. Click the “console” tab.

Safari

  • Press CMD + ALT + I to open the Web Inspector.
  • See Chrome’s step 2. (Chrome and Safari have pretty much identical dev tools.)

IE9

  1. Press F12 to open the developer tools.
  2. Click the “console” tab.

Firefox

  • Press CTRL + SHIFT + K to open the Web console (COMMAND + SHIFT + K on Macs).
  • or, if Firebug is installed (recommended):
    1. Press F12 to open Firebug.
    2. Click on the “console” tab.

Opera

  1. Press CTRL + SHIFT + I to open Dragonfly.
  2. Click on the “console” tab.

skjnldsv avatar Oct 26 '22 15:10 skjnldsv

Additional information: the menu in "+ Add" only appears when there is at least one album.

nicokaiser avatar Oct 26 '22 17:10 nicokaiser

Seems like I triggered multiple bugs with this, but here is a screen cast:

https://user-images.githubusercontent.com/238631/198092040-dd840612-7856-4ec3-8fc3-18d8b94e5492.mp4

I did this:

  • Open the Photos app
  • Create a new Album ("Test")
  • Open "Folders" view
  • Click "+ Add" => Menu opens
  • In the menu, click "+ Add photos to this album" => nothing happens
  • In the Albums view, delete the album
  • Open "Folders" view => thumbnails have disappeared (but the "+ Add photos to this album" menu item is still there)
  • Reload the page => thumbnails re-appear
  • Click "+ Add" => no menu, upload file prompt is shown correctly
  • Upload an image
  • Click on the uploaded image => 404 (maybe wrong URL in state)
  • Reload the page, click on the uploaded image => shows correctly

There seems to be something wrong with the state management or something...

nicokaiser avatar Oct 26 '22 17:10 nicokaiser

Ah, a state mismatch! Nice found! :) I'll investigate soon

skjnldsv avatar Oct 26 '22 17:10 skjnldsv