photos icon indicating copy to clipboard operation
photos copied to clipboard

Published 20 hours ago • verified publisher icon nextcloud

Add public link logic

Open artonge opened this issue 1 year ago • 1 comments

In a working state

  • [x] Fix the name of the album, it is currently the token
  • [ ] Replace file picker by upload file button in header
  • [x] Fix file removable
  • [x] Prettify header menu action
  • [ ] Can't open file in viewer

artonge avatar Sep 21 '22 14:09 artonge

/backport to stable25

artonge avatar Sep 22 '22 14:09 artonge

Important changes I made after realizing that I didn't test without being logged in…

  • Added a /dav/photospublic/{token} endpoint to not have conflict with /dav/photos/{user} https://github.com/nextcloud/photos/pull/1278/commits/5b0a3a9c4b3a5c0de16d8e32f417876d6fb7ab64#diff-445ce42266f69bcf9d421f81e31170379e803befd4eddd72851cd99ddc91a56cR34-R87

  • Intercept webdav request in the backend to authenticate public access with a token Listener: https://github.com/nextcloud/photos/pull/1278/files#diff-213bbab031403681106d94580acb181d9cde8a708293283a9e620b542c390d8c And auth backend: https://github.com/nextcloud/photos/pull/1278/commits/5b0a3a9c4b3a5c0de16d8e32f417876d6fb7ab64#diff-5464ecee14465d8a62cbbd7926c8b83b7667752403a7d58098a816f925a52bc5R58-R74

  • For that, I needed to add type authentication in info.xml to intercept them early enough https://github.com/nextcloud/photos/pull/1278/files#diff-ab97a56738913a50d2334c4d3f10991748d3e29d011f5a674734b63d33d5ce9eR15

@PVince81 can you validate the approach ?

artonge avatar Sep 29 '22 08:09 artonge