photos
photos copied to clipboard
Add Albums view
:heavy_check_mark: Done and ready for reviews :heavy_check_mark:
Side quests
- [ ] Long press on mobile ?
- [ ] Use exif data to sort files
- [ ] Bug in
DAV:SEARCH
sorted by creationdate (some files from page 2 are before some files of page 1) - [ ] Issue with
nc-vue::Action
when parent is sticky - [ ] Sharing
- [ ] Internal and link sharing of albums should be possible to make it on par with folders
- [ ] See mockups,
- [ ] Uploading via link would be nice
- [ ] Federation can be left out for now
- [ ] When you add a photo, or others upload a photo, they both land in "Photos" – that’s the default, and it’s configurable
Screenshots
Empty album list | Album list with content |
---|---|
![]() |
![]() |
Album form modal | Album form with a name filled | Album form loading |
---|---|---|
![]() |
![]() |
![]() |
Empty album content | Album content with content | Renaming an album |
---|---|---|
![]() |
![]() |
![]() |
File picker preloading | File picker with content | File picker loading |
---|---|---|
![]() |
![]() |
![]() |
Album picker | Album picker preloading |
---|---|
![]() |
![]() |
Jan's notes
@jancborchardt See unchecked items for questions or validation :)
- [ ] Add button has a bit too much space between + and "Add" text --> It is the default for Action buttons. Should be fixed in nc-vue.
- [x] Space below "Add" button is a bit too much in "All media" (it’s fine in the Albums view) --> Change margin-top 60px to 0px
- [ ] Favorite icon is not so visible, possibly give it a white outline
--> Added, but I think it looks weird:
- [x] Multiselect and albums menu:
- [x] Download icon in multiselect menu is outlined, should be standard filled style
- [x] "Delete files from album" should be "Remove items from album"? With an X icon
- [x] Delete icon is not standard Material Design delete icon
Album view
- [ ] Because of large padding of --> ??
- [x] Album date: Range of the date of the pictures in the album, e.g. "January–February 2022"
- [x] Album picture picker: Center loading spinner → Even better: Use skeleton screens with shimmer
--> Is this solution ok with you?
- [x] "Add photos" button to confirm should be on bottom right of dialog
- [x] Button wording should include album name: "Add photos to Sailing vacation"
Favorite icon is not so visible, possibly give it a white outline **--> Added, but I think it looks weird:
Suggestion :
- when Selecting/Hovering the image : adding a transparent black layer between thumbnail and fav icon
- and otherwise do not display fav icon
@icewind1991 Can you review and or amend my work on the backend if needed ?
Thanks a lot for this work! :clap: Photos are my main use-case for Nextcloud, improvements like these are very welcome :heart: