photos icon indicating copy to clipboard operation
photos copied to clipboard

Add Albums view

Open artonge opened this issue 2 years ago • 3 comments

:heavy_check_mark: Done and ready for reviews :heavy_check_mark:

Side quests

  • [ ] Long press on mobile ?
  • [ ] Use exif data to sort files
  • [ ] Bug in DAV:SEARCH sorted by creationdate (some files from page 2 are before some files of page 1)
  • [ ] Issue with nc-vue::Action when parent is sticky
  • [ ] Sharing
    • [ ] Internal and link sharing of albums should be possible to make it on par with folders
    • [ ] See mockups,
    • [ ] Uploading via link would be nice
    • [ ] Federation can be left out for now
    • [ ] When you add a photo, or others upload a photo, they both land in "Photos" – that’s the default, and it’s configurable

Screenshots

Empty album list Album list with content
Screenshot 2022-08-11 at 12-05-14 Photos - Nextcloud Screenshot from 2022-08-11 12-04-25
Album form modal Album form with a name filled Album form loading
Screenshot from 2022-08-11 12-05-36 Screenshot from 2022-08-11 12-05-56 Screenshot from 2022-08-11 12-06-12
Empty album content Album content with content Renaming an album
Screenshot 2022-08-11 at 11-44-05 Photos - Nextcloud Screenshot 2022-08-11 at 11-38-16 Photos - Nextcloud Screenshot 2022-08-11 at 11-39-11 Photos - Nextcloud
File picker preloading File picker with content File picker loading
Screenshot from 2022-08-11 11-47-41 Screenshot 2022-08-11 at 11-39-38 Photos - Nextcloud Screenshot 2022-08-11 at 12-13-56 Photos - Nextcloud
Album picker Album picker preloading
Screenshot 2022-08-11 at 12-16-52 Photos - Nextcloud Screenshot from 2022-08-11 11-47-21

artonge avatar Jul 27 '22 15:07 artonge

Jan's notes

@jancborchardt See unchecked items for questions or validation :)

  • [ ] Add button has a bit too much space between + and "Add" text --> It is the default for Action buttons. Should be fixed in nc-vue.
  • [x] Space below "Add" button is a bit too much in "All media" (it’s fine in the Albums view) --> Change margin-top 60px to 0px
  • [ ] Favorite icon is not so visible, possibly give it a white outline --> Added, but I think it looks weird: Screenshot from 2022-08-10 14-40-57
  • [x] Multiselect and albums menu:
    • [x] Download icon in multiselect menu is outlined, should be standard filled style
    • [x] "Delete files from album" should be "Remove items from album"? With an X icon
    • [x] Delete icon is not standard Material Design delete icon

Album view

  • [ ] Because of large padding of --> ??
  • [x] Album date: Range of the date of the pictures in the album, e.g. "January–February 2022"
  • [x] Album picture picker: Center loading spinner → Even better: Use skeleton screens with shimmer --> Is this solution ok with you? Screenshot from 2022-08-10 15-55-53
  • [x] "Add photos" button to confirm should be on bottom right of dialog
  • [x] Button wording should include album name: "Add photos to Sailing vacation"

artonge avatar Aug 10 '22 12:08 artonge

Favorite icon is not so visible, possibly give it a white outline **--> Added, but I think it looks weird:

Suggestion :

  • when Selecting/Hovering the image : adding a transparent black layer between thumbnail and fav icon
  • and otherwise do not display fav icon

axellebot avatar Aug 10 '22 13:08 axellebot

@icewind1991 Can you review and or amend my work on the backend if needed ?

artonge avatar Aug 10 '22 14:08 artonge

Thanks a lot for this work! :clap: Photos are my main use-case for Nextcloud, improvements like these are very welcome :heart:

nicorikken avatar Aug 24 '22 05:08 nicorikken