passman icon indicating copy to clipboard operation
passman copied to clipboard

Make it compatible with nextcloud dark mode [$10]

Open shyaminayesh opened this issue 5 years ago • 6 comments

Bug report

Steps to reproduce

  1. Install NC 17
  2. Install Passman v2.3.4
  3. Activate NextCloud Dark theme from ( Settings > Accessibility )

Expected behaviour

Passman with dark theme support.

Actual behaviour

image

Configuration

Operating system: Debian 9 Browser: Chromium 79.0 Extensions that might cause interference: Passman Passman version: 2.3.4 Web server: Nginx Database: MariaDB PHP version: 7.3 cloud server: Nextcloud cloud version: 17.0.1


There is a $10 open bounty on this issue. Add to the bounty at Bountysource.

shyaminayesh avatar Dec 20 '19 10:12 shyaminayesh

This commit looks like a great starting point: https://github.com/nextcloud/activity/commit/0473fd324535ed402ac1c92e46d7fbbe66db8332.

Instead of explicit colors like:

 	border: 1px solid #ddd;

...we'll probably want to use variables to set the colors, like this:

 	border: 1px solid var(--color-border-dark);

synthead avatar Apr 16 '20 04:04 synthead

beta version. passman.min.zip Now i try to make pull request

Luckyvb avatar Oct 08 '20 21:10 Luckyvb

https://github.com/Luckyvb/passman/commit/b0c9ec879c5c053bd0cc797878abf1983b0c9917

Luckyvb avatar Oct 08 '20 22:10 Luckyvb

Hi, I was working on this too. Do you need some help?

skervista avatar Oct 09 '20 08:10 skervista

my changes look good. but need right changes to make pool request and maybe refactoring. изображение

Luckyvb avatar Oct 12 '20 08:10 Luckyvb

you could also try https://apps.nextcloud.com/apps/breezedark it colours my passman perfectly :)

binsky08 avatar Mar 12 '21 23:03 binsky08