passman icon indicating copy to clipboard operation
passman copied to clipboard

Fixed white on white issue when header background is RBG color

Open alexcustos opened this issue 6 years ago • 3 comments

There is a problem with white themes. For some reason, jQuery returns RGB color which cannot be processed well by use-theme directive. Here the fix for this issue.

alexcustos avatar Jun 09 '18 05:06 alexcustos

Tests are failing due to #497

vwbusguy avatar Sep 13 '18 17:09 vwbusguy

@alexcustos Can you explain how to reproduce this error exactly and for what to watch out so that i can test this?

Also, could you sign your commits? Without that we cannot merge them :/

newhinton avatar Dec 10 '18 10:12 newhinton

@newhinton I'm not using Passman anymore. A lot of changed in Nextcloud theming since that time, so I'm not sure if this issue still relevant. But it was easy to reproduce by setting the primary color to #FFFFFF in the default theming app. Entire Nextcloud handled it very well, but not Passman.

alexcustos avatar Dec 11 '18 04:12 alexcustos