passman-webextension icon indicating copy to clipboard operation
passman-webextension copied to clipboard

custom field autofill not working with multiple matches per domain

Open jficz opened this issue 7 years ago • 3 comments

Steps to reproduce

  1. create multiple accounts (entries) with the same custom field in Passman for a site with custom fields in login form (i.e. AWS IAM login with custom field labeled "#account")
  2. edit the custom field with different values for each account
  3. visit the URL in question

Expected behaviour

When an account is selected from password picker, the custom #field should be filled as well. I am trying this on Amazon AWS console login (https://signin.aws.amazon.com).

Actual behaviour

The custom field is not filled while user and password fields are.

Configuration

Operating system: Linux

Browser: Firefox 61

Extensions that might cause interference: none

Passman version: 2.1.4

Extension version: 2.1.1

Nextcloud version: 13.0.0

Browser log

N/A


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

jficz avatar Jul 17 '18 20:07 jficz

I had some very similar issue, which I reported here: Issue #264

While I used some iOS client to get access to my vault on iOS, I was alerted that there were issues with duplicate names for some credentials in my vault. At first, I blamed the iOS client for using the credentials names for unique keys and since I knew, I had some and the password collector itself doesn't seem to care about that, I thought that these names needn't to be unique, but for the sake of the iOS client, I edited the duplicate credentials to satisfy the iOS client.

Then I checked in on my passman web-extension and suddenly two things changed:

  • auto-fill started to work again as it did before, I switched on the passwort collector
  • Firefox doesn't suck my battery empty in no time anymore - that had also been a real pita before

So, maybe not only duplicate credential names cause these issue, if you are sure, that your creds are all named uniquely.

budachst avatar Jul 31 '18 19:07 budachst

Not sure I understand. In my case, I have two separate and independent entries (accounts) set up in Passman, where only the URL field has the same value in both.

They both have a custom field named #account, which corresponds to a login form input with id "account". This login form has three fields - account, username and password. Both username and password are filled correctly when the desired entry is clicked on while the account field is not filled at all.

I'm not sure I see any relation to #264 here.

jficz avatar Jul 31 '18 20:07 jficz

I see what you mean. When I encountered my issue, I only reported a very basic issue, since I didn't relate the issue to the duplicate names in my vault. It was only when I fired up the iOS simulator to check the iOS client, that the client complained about duplicate names.

In your case it's a duplicate custom field, but my assumption is, that the webextension has a general diasbility to deal with those in general.

budachst avatar Jul 31 '18 20:07 budachst