ocsms icon indicating copy to clipboard operation
ocsms copied to clipboard

l10n: Add singular and plural

Open Valdnet opened this issue 5 years ago • 6 comments

I propose to add singular and plural variation for a text string:

  • %s messages shown of %s messages stored in database.

https://github.com/nextcloud/ocsms/blob/5391cd9c3f67ca6da517f8dc885b53171a657832/templates/main.php#L121

May be helpful: https://github.com/nextcloud/server/blob/a2a3b87c19662f06cfb804b9fead7e939b1c3e6c/core/src/globals.js#L139-L148

Valdnet avatar Sep 27 '20 11:09 Valdnet

Could you provide a PR for this change?

e-alfred avatar Dec 24 '20 16:12 e-alfred

@e-alfred I think this should be done by someone who knows more about PHP programming 😉.

Valdnet avatar Dec 27 '20 15:12 Valdnet

Is this the only occurrence? Did you find more instances that should be changed? I changed this particular one last time at the request of @rakekniven.

e-alfred avatar Dec 27 '20 15:12 e-alfred

Is this the only occurrence? Did you find more instances that should be changed?

So far, only this string text has noticed.

Valdnet avatar Dec 27 '20 16:12 Valdnet

Just did a blame and remember now :-) My thoughts have been that you will not have only one message in your database and instead of overworking the code I just made a tiny suggestion to only use plural form.

rakekniven avatar Dec 29 '20 07:12 rakekniven

My thoughts have been that you will not have only one message in your database

@rakekniven But you also have to take into account the number of messages to be displayed :wink:.

Valdnet avatar Dec 29 '20 09:12 Valdnet