notify_push icon indicating copy to clipboard operation
notify_push copied to clipboard

feat(Dockerfile): switch cmd to entrypoint

Open SimJoSt opened this issue 4 years ago • 4 comments
trafficstars

By using ENTRYPOINT for the default command, it is possible to extend the command with arguments by using CMD in a custom Dockerfile. As the command itself doesn't need to be changed/overwritten with this approach, changes to the location of the binary or command will not break these configurations in the future.

SimJoSt avatar Aug 07 '21 13:08 SimJoSt

@SimJoSt checks require a signoff :)

git commit --amend --no-edit --signoff
git push --force-with-lease origin feat/Dockerfile/switch-cmd-to-entrypoint

Pytal avatar Aug 09 '21 20:08 Pytal

The problem with changing that now is that it would break all existing setups that use the existing CMD overwrite

icewind1991 avatar Aug 18 '21 14:08 icewind1991

The problem with changing that now is that it would break all existing setups that use the existing CMD overwrite

True, I do still think this is a good Docker standard to follow though :) Should we reconsider this when we near 1.0?

Pytal avatar Aug 18 '21 20:08 Pytal

@icewind1991 @Pytal @alerque I finally got a grip on all my PRs and updated this one as well. So it is ready to be merged when it's time.

SimJoSt avatar Jun 19 '23 11:06 SimJoSt