notifications icon indicating copy to clipboard operation
notifications copied to clipboard

Trigger a proper event-bus event

Open nickvergessen opened this issue 5 years ago • 5 comments

As per https://github.com/nextcloud/nextcloud-event-bus/issues/131

nickvergessen avatar Sep 02 '20 09:09 nickvergessen

Only listened to in https://github.com/nextcloud/server/blob/d5e854e7efda5572682988faeef500e6f71a7b57/apps/files/js/filelist.js#L380-L384 and https://github.com/nextcloud/server/blob/ab2b3d2755e0b1d54bac84f842426b0b8d3aa006/apps/federatedfilesharing/js/external.js#L86-L91

But that code is not transpiled so I'm not sure how to use the subscribe there

nickvergessen avatar Sep 02 '20 09:09 nickvergessen

@nickvergessen do we still want to add this?

Pytal avatar Apr 21 '22 17:04 Pytal

Yes, so we can get rid of jQuery in this app

nickvergessen avatar Apr 25 '22 11:04 nickvergessen

Yes, so we can get rid of jQuery in this app

🚀! Anything blocking other than the comments above?

Pytal avatar Apr 25 '22 17:04 Pytal

The most important bit would be to adjust the listeners as outlined above. That is the part I failed to do.

nickvergessen avatar Apr 25 '22 17:04 nickvergessen