notifications icon indicating copy to clipboard operation
notifications copied to clipboard

Get rid of or bundle jquery

Open rullzer opened this issue 5 years ago • 3 comments

Since we want apps to be as independant as possible we should kill the use of the global jquery. Some options

  1. We add jquery as hard dep here
  2. We make the code not use jquery

I would like 2 since I guess it is a lot cleaner. But 1 is always an option.

cc: @nickvergessen @skjnldsv @ChristophWurst @juliushaertl

rullzer avatar May 10 '20 19:05 rullzer

Can think about it, once OC.registerMenu does not require jquery objects anymore.

nickvergessen avatar May 10 '20 22:05 nickvergessen

Or use https://nextcloud-vue-components.netlify.app/#/Components/Popover?id=popover :wink:

juliusknorr avatar May 11 '20 06:05 juliusknorr

[Vue warn]: Error in mounted hook: "ReferenceError: $ is not defined" ---> <NotificationsApp> at src/NotificationsApp.vue

Got this on the vite migration of server (due to dropped global jQuery there). We should migrate this soon :tm:

susnux avatar May 02 '24 22:05 susnux