implement in-app-wiki

[newhinton]

Signed-off-by: Felix Nüsse [email protected] closes #287

Todo:

• [x] Add close button to wikipage
• [x] Add translations everywhere
• [x] Fix offset in Navigationbar
• [x] Add tips
• [x] Make tables look better
• [x] Embedd appstore icons
• [x] Fix styling for Apps
• [ ] fix all console errors
• [ ] add link to help to welcome page (maybe even replace it?)
• [x] create sample-note from wiki and welcome page

Welcomescreen	Help	Help

Discussion:

• [ ] What shortcuts to add
• [ ] What markdown codes to add
• [ ] What tipps to add

[newhinton]

~~@korelstar I would like to not reference the appstore badges (and app-icons maybe) via url. I would like to embedd them as assets. However, i could not find out how nextcloud stores static assets, do you know that? One clunky way would be to embedd them base64 encoded in a helper class, but that seems unclean~~

Edit: found out!

[newhinton]

@stefan-niedermann How would you like to be attributed for your app? Is this okay?

[newhinton]

I think we could easily put this with all the other outstanding features into a Version 5.0.0. It's a nice round number, and there was quite a bit of work done to justify it :+1:

[korelstar]

Hey @newhinton : Thanks for your work on this! The screenshots are looking very well so far. Since you are still actively working on this PR, I wait with a final review. But it's going in a good direction!

But I have one request: could you please set this (and other not yet finished) PRs to "draft"? It would be very helpful to have a direct insight if a PR is ready for review or not.

Regarding the version name: I'm using the milestone planing. The plan was to release version 4.4.0 several weeks ago. It should have contained all the stuff that change the public API (attachments, custom file extension) -- but the last thing is still left, since I've not found the time :-( . After that, the plan was to release 4.5.0 with all the UI stuff (three-column layout, help-screen, toolbar etc.). Version 5.0.0 was planned with the switch to the Nextcloud Text editor, but that is currently halted due to the open issues regarding the Text app.

[newhinton]

Yes i will convert everything to drafts soon.

However, this is not so drafty-anymore, it is mostly done and we need to discuss content.

Regarding 5.0.0: Since we more or less implement everything text does (except concurrent editing), do we need that issue at all? It does not seem that the issues will be fixed anytime soon, if at all, and since we have a very well working setup with the new additions, i think we can do without it until something major changes.

[korelstar]

@newhinton Is there anything to be done here? Could you please rebase the branch when this is ready to review?

[newhinton]

Yes and no :D

I think the technical side is done. There was the question wether or not to replace the initial welcome-page with a popup, but this can be done later.

However, we should check two things: First, if all app-maintainer are okay with beeing mentioned on that page And second, if we have all keyboard-shortcuts and tips in the help that we want.

But besides that, i think its good to go. (When i will rebase this, i'll also check if there are still console errors)

[korelstar]

First, if all app-maintainer are okay with beeing mentioned on that page

Any veto @stefan-niedermann @phedlund ?

And second, if we have all keyboard-shortcuts and tips in the help that we want.

I'll do a deeper review.

[stefan-niedermann]

How would you like to be attributed for your app? Is this okay?

That's fine, thanks 👍

Any veto @stefan-niedermann?

Nope 🙂

[newhinton]

@korelstar I have implemented a lot of the changes you mentioned.

However, do we have any tips we want to add? Otherwise i need to remove that section from the help.

[newhinton]

~Oh damn. I broke something badly, i somewhere have the three column layout merged in there.~

Fixed it.

[newhinton]

@korelstar So i did rebase, but it did not want to push. For now i have not force pushed my code, but created a second branch.

You can check it here: https://github.com/nextcloud/notes/tree/feature/noid/help2

If it works for you, i can force push later.

~There is one bug i encountered: Closing or Opening the sidebar toggles the help. I will have to check that~

[korelstar]

Hey @newhinton ! I did a rebase of feature/noid/help2 to current master and fixed all the issues that I've criticized. I've pushed the new stuff to feature/noid/help (this PR). Please have a look from your side on this. I will do a last review after that.

[newhinton]

@korelstar It looks good to me! Thanks for helping out