notes icon indicating copy to clipboard operation
notes copied to clipboard

Sharing of notes not possible

Open Schubi2024 opened this issue 10 months ago • 7 comments

Steps to reproduce

  1. Creating a new note
  2. Click the share Button
  3. Settings for sharing are empty

Screenshots

Image

Server

Please complete the following information.

  • Notes app version: 4.11.0
  • Nextcloud version: 31
  • OS: debian
  • Web server: nginx
  • PHP version: 8.3.17
  • Database:

Nextcloud configuration: { "system": { "instanceid": "REMOVED SENSITIVE VALUE", "passwordsalt": "REMOVED SENSITIVE VALUE", "secret": "REMOVED SENSITIVE VALUE", "trusted_domains": [ "localhost", "xyz.123" ], "datadirectory": "REMOVED SENSITIVE VALUE", "dbtype": "mysql", "version": "31.0.0.18", "overwrite.cli.url": "https://xyt.123", "dbname": "REMOVED SENSITIVE VALUE", "dbhost": "REMOVED SENSITIVE VALUE", "dbport": "", "dbtableprefix": "oc_", "mysql.utf8mb4": true, "dbuser": "REMOVED SENSITIVE VALUE", "dbpassword": "REMOVED SENSITIVE VALUE", "installed": true, "activity_expire_days": 14, "auth.bruteforce.protection.enabled": true, "forbidden_filenames": [ ".htaccess", "Thumbs.db", "thumbs.db" ], "cron_log": true, "enable_previews": true, "enabledPreviewProviders": [ "OC\Preview\PNG", "OC\Preview\JPEG", "OC\Preview\GIF", "OC\Preview\BMP", "OC\Preview\XBitmap", "OC\Preview\Movie", "OC\Preview\PDF", "OC\Preview\MP3", "OC\Preview\TXT", "OC\Preview\MarkDown", "OC\Preview\Image", "OC\Preview\HEIC", "OC\Preview\TIFF", "OC\Preview\MKV", "OC\Preview\MP4", "OC\Preview\AVI" ], "trusted_proxies": "REMOVED SENSITIVE VALUE", "filesystem_check_changes": 1, "check_data_directory_permissions": false, "default_phone_region": "DE", "default_language": "de", "default_locale": "de_DE", "lost_password_link": "disabled", "filelocking.enabled": "false", "allow_self_signed": true, "allow_local_address": true, "allow_local_remote_servers": true, "share_folder": "/Shares", "htaccess.RewriteBase": "/", "integrity.check.disabled": false, "knowledgebaseenabled": false, "logfile": "/var//tmp/nextcloud.log", "loglevel": 2, "logtimezone": "Europe/Berlin", "log_rotate_size": 104857600, "maintenance": false, "maintenance_window_start": 1, "memcache.local": "\OC\Memcache\APCu", "memcache.locking": "\OC\Memcache\Redis", "memcache.distributed": "\OC\Memcache\Redis", "overwriteprotocol": "https", "preview_max_x": 2048, "preview_max_y": 2048, "preview_max_scale_factor": 1, "redis": { "host": "REMOVED SENSITIVE VALUE", "port": 0, "timeout": 0 }, "quota_include_external_storage": false, "skeletondirectory": "/mnt/nextclouddata/benutzer_vorlage", "theme": "", "trashbin_retention_obligation": "auto, 7", "updater.release.channel": "stable", "mail_from_address": "REMOVED SENSITIVE VALUE", "mail_smtpmode": "smtp", "mail_sendmailmode": "smtp", "mail_domain": "REMOVED SENSITIVE VALUE", "mail_smtphost": "REMOVED SENSITIVE VALUE", "app_install_overwrite": [ "groupfolders", "bruteforcesettings", "tasks", "otpmanager", "news", "sharelisting", "files_fulltextsearch_tesseract", "bookmarks_fulltextsearch", "fulltextsearch", "fulltextsearch_elasticsearch", "files_fulltextsearch", "maps", "memories", "passwords", "thesearchpage", "files_downloadactivity", "onlyoffice" ], "mail_smtpport": "25", "mail_smtptimeout": 30, "mail_smtpauthtype": "NTLM", "mail_smtpauth": 1, "mail_smtpname": "REMOVED SENSITIVE VALUE", "mail_smtppassword": "REMOVED SENSITIVE VALUE", "twofactor_enforced": "true", "twofactor_enforced_groups": [], "twofactor_enforced_excluded_groups": [ "Speziale" ], "remember_login_cookie_lifetime": 0, "session_lifetime": 900, "session_keepalive": false, "auto_logout": true, "forbidden_filename_characters": [ "<", ">", ":", """, "|", "?", "*", "\", "/" ], "forbidden_filename_extensions": [ " ", ".", ".filepart", ".part" ], "memories.db.triggers.fcu": true, "memories.exiftool": "/var/www/nextcloud/apps/memories/bin-ext/exiftool-amd64-glibc", "memories.vod.path": "/var/www/nextcloud/apps/memories/bin-ext/go-vod-amd64", "memories.vod.ffmpeg": "/usr/bin/ffmpeg", "memories.vod.ffprobe": "/usr/bin/ffprobe", "memories.gis_type": 1, "preview_max_memory": 2028, "preview_max_filesize_image": 512, "forbidden_filename_basenames": [ "con", "prn", "aux", "nul", "com0", "com1", "com2", "com3", "com4", "com5", "com6", "com7", "com8", "com9", "com\u00b9", "com\u00b2", "com\u00b3", "lpt0", "lpt1", "lpt2", "lpt3", "lpt4", "lpt5", "lpt6", "lpt7", "lpt8", "lpt9", "lpt\u00b9", "lpt\u00b2", "lpt\u00b3" ] } }

Enabled:

  • activity: 4.0.0
  • admin_audit: 1.21.0
  • bruteforcesettings: 4.0.0
  • calendar: 5.1.3
  • circles: 31.0.0-dev.0
  • cloud_federation_api: 1.14.0
  • collectives: 2.16.1
  • comments: 1.21.0
  • contacts: 7.0.3
  • contactsinteraction: 1.12.0
  • dashboard: 7.11.0
  • dav: 1.33.0
  • deck: 1.15.0
  • federatedfilesharing: 1.21.0
  • federation: 1.21.0
  • files: 2.3.1
  • files_antivirus: 6.0.0
  • files_downloadlimit: 4.0.0
  • files_fulltextsearch: 31.0.0
  • files_fulltextsearch_tesseract: 27.0.1
  • files_pdfviewer: 4.0.0
  • files_reminders: 1.4.0
  • files_sharing: 1.23.1
  • files_trashbin: 1.21.0
  • files_versions: 1.24.0
  • forms: 5.0.3
  • fulltextsearch: 31.0.0
  • fulltextsearch_elasticsearch: 31.0.0
  • groupfolders: 19.0.3
  • integration_mastodon: 3.1.1
  • integration_paperless: 1.0.6
  • logreader: 4.0.0
  • lookup_server_connector: 1.19.0
  • maps: 1.6.0
  • memories: 7.5.2
  • news: 25.3.0
  • nextcloud_announcements: 3.0.0
  • notes: 4.11.0
  • notifications: 4.0.0
  • notify_push: 1.0.0
  • oauth2: 1.19.1
  • otpmanager: 0.5.4
  • password_policy: 3.0.0
  • passwords: 2025.2.20
  • photos: 4.0.0-dev.1
  • previewgenerator: 5.8.0
  • privacy: 3.0.0
  • profile: 1.0.0
  • provisioning_api: 1.21.0
  • recommendations: 4.0.0
  • related_resources: 2.0.0
  • richdocuments: 8.6.2
  • richdocumentscode: 24.4.1204
  • serverinfo: 3.0.0
  • settings: 1.14.0
  • sharebymail: 1.21.0
  • sharelisting: 1.2.0
  • sharereview: 1.3.3
  • spreed: 21.0.1
  • support: 3.0.0
  • systemtags: 1.21.1
  • tables: 0.9.0
  • tasks: 0.16.1
  • text: 5.0.0
  • theming: 2.6.1
  • thesearchpage: 1.3.0-pre
  • twofactor_backupcodes: 1.20.0
  • twofactor_totp: 13.0.0-dev.0
  • twofactor_webauthn: 2.1.0
  • updatenotification: 1.21.0
  • user_status: 1.11.0
  • viewer: 4.0.0
  • weather_status: 1.11.0
  • webhook_listeners: 1.2.0
  • workflowengine: 2.13.0 Disabled:
  • app_api: 5.0.2 (installed 3.2.0)
  • encryption: 2.19.0
  • files_downloadactivity: 1.17.0 (installed 1.17.0)
  • files_external: 1.23.0 (installed 1.12.0)
  • firstrunwizard: 4.0.0 (installed 2.9.0)
  • onlyoffice: 9.7.0 (installed 9.7.0)
  • survey_client: 3.0.0 (installed 1.8.0)
  • suspicious_login: 9.0.1
  • twofactor_nextcloud_notification: 5.0.0
  • user_ldap: 1.22.0

Client

Please complete the following information.

  • Browser (incl. version): Chrome, FireFox
  • OS: Win11 Pro

Schubi2024 avatar Mar 13 '25 07:03 Schubi2024

Am experiencing this as well.

atrauzzi avatar Mar 16 '25 11:03 atrauzzi

Me too. Only way to share it is through files. I would love to see better sharing of notes including attachments (and inline photo / video) as well.

Japhys avatar Mar 24 '25 06:03 Japhys

Same thing happening here. Everything is up-to-date. Refreshing the page and trying to share will populate the panel and it will work.

  • This issue only happens when you stay on the notes page for a while then when you try to share a note it will display an empty share panel.

  • If more info is required i am more than happy to share configs, console logs, or even show the issue in a video with the devs.

Would love to see this fixed as it is pretty annoying. Thanks.

codingPotato21 avatar Mar 30 '25 00:03 codingPotato21

Currently can't reproduce. It seems like there are some special conditions involved

enjeck avatar Apr 26 '25 23:04 enjeck

  • If more info is required i am more than happy to share configs, console logs, or even show the issue in a video with the devs.

@codingPotato21 That'll be hepful :)

enjeck avatar Apr 26 '25 23:04 enjeck

Okay, was able to reproduce, although not sure what caused it. Problem seems to stem from https://github.com/nextcloud/notes/blob/0bb7b5d1d9a489b347c90b48d49b2ecce2dac581/src/components/NoteItem.vue#L296, where the value of this.note.internalPath does not actually match the internal path of the currently selected Note.

Console errors

toolbar.js:24 
            
            
           PROPFIND http://nextcloud.local/remote.php/dav/files/admin/Notes/New%20note%20(2).md 500 (Internal Server Error)
window.fetch @ toolbar.js:24
(anonymous) @ xhr-request.js:125
(anonymous) @ dav-Co9y-hkg.mjs:624
(anonymous) @ index.js:2
execute @ index.js:2
patchInline @ index.js:2
(anonymous) @ index.js:2
(anonymous) @ index.js:2
execute @ index.js:2
patchInline @ index.js:2
et @ index.js:2
(anonymous) @ index.js:2
push../node_modules/webdav/dist/web/index.js.e @ index.js:2
(anonymous) @ index.js:2
push../node_modules/webdav/dist/web/index.js.n @ index.js:2
stat @ index.js:2
fetchNode @ WebdavClient.ts:5
open @ Sidebar.vue:366
onToggleSharing @ NoteItem.vue:176
invokeWithErrorHandling @ vue.runtime.esm.js:3033
invoker @ vue.runtime.esm.js:1832
invokeWithErrorHandling @ vue.runtime.esm.js:3033
(anonymous) @ vue.runtime.esm.js:3732
onClick @ actionText-fFcUPi2g.mjs:77
handleClick @ NcActionButton-Gpv56vuS.mjs:171
invokeWithErrorHandling @ vue.runtime.esm.js:3033
invoker @ vue.runtime.esm.js:1832
(anonymous) @ vue.runtime.esm.js:7500Understand this errorAI
Sidebar.vue:385 Error while loading the file data Error: Invalid response: 500 Internal Server Error
    at qt (index.js:2:1)
    at Ht (index.js:2:1)
    at index.js:2:1
    at async fetchNode (WebdavClient.ts:5:1)
    at async VueComponent.open (Sidebar.vue:366:1)
open @ Sidebar.vue:385
await in open
onToggleSharing @ NoteItem.vue:176
invokeWithErrorHandling @ vue.runtime.esm.js:3033
invoker @ vue.runtime.esm.js:1832
invokeWithErrorHandling @ vue.runtime.esm.js:3033
(anonymous) @ vue.runtime.esm.js:3732
onClick @ actionText-fFcUPi2g.mjs:77
handleClick @ NcActionButton-Gpv56vuS.mjs:171
invokeWithErrorHandling @ vue.runtime.esm.js:3033
invoker @ vue.runtime.esm.js:1832
(anonymous) @ vue.runtime.esm.js:7500Understand this errorAI
Sidebar.vue:386 Uncaught (in promise) Error: Error: Invalid response: 500 Internal Server Error
    at VueComponent.open (Sidebar.vue:386:1)

Server logs

nextcloud-1  | [Sun Apr 27 00:28:54.452261 2025] [php:notice] [pid 1649:tid 1649] [client 192.168.21.5:45290] PHP Fatal error:  Declaration of Psr\\Log\\AbstractLogger::emergency($message, array $context = []) must be compatible with Psr\\Log\\LoggerInterface::emergency(Stringable|string $message, array $context = []): void in /var/www/html/apps-extra/tables/vendor/psr/log/Psr/Log/AbstractLogger.php on line 22
nextcloud-1  | [Sun Apr 27 00:28:54.452285 2025] [php:notice] [pid 1649:tid 1649] [client 192.168.21.5:45290] PHP Stack trace:
nextcloud-1  | [Sun Apr 27 00:28:54.452287 2025] [php:notice] [pid 1649:tid 1649] [client 192.168.21.5:45290] PHP   1. {main}() /var/www/html/remote.php:0
nextcloud-1  | [Sun Apr 27 00:28:54.452288 2025] [php:notice] [pid 1649:tid 1649] [client 192.168.21.5:45290] PHP   2. require_once() /var/www/html/remote.php:147
nextcloud-1  | [Sun Apr 27 00:28:54.452289 2025] [php:notice] [pid 1649:tid 1649] [client 192.168.21.5:45290] PHP   3. OCA\\DAV\\Server->exec() /var/www/html/apps/dav/appinfo/v2/remote.php:22
nextcloud-1  | [Sun Apr 27 00:28:54.452290 2025] [php:notice] [pid 1649:tid 1649] [client 192.168.21.5:45290] PHP   4. OCA\\DAV\\Connector\\Sabre\\Server->start() /var/www/html/apps/dav/lib/Server.php:410
nextcloud-1  | [Sun Apr 27 00:28:54.452295 2025] [php:notice] [pid 1649:tid 1649] [client 192.168.21.5:45290] PHP   5. Sabre\\DAV\\Server->emit($eventName = 'exception', $arguments = [0 => class Sabre\\DAV\\Exception\\NotFound { protected $message = 'File with name /Notes/New note (2).md could not be located'; private string ${Exception}string = ''; protected $code = 0; protected string $file = '/var/www/html/apps/dav/lib/Connector/Sabre/Directory.php'; protected int $line = 195; private array ${Exception}trace = [...]; private ?Throwable ${Exception}previous = NULL }], $continueCallBack = *uninitialized*) /var/www/html/apps/dav/lib/Connector/Sabre/Server.php:52
nextcloud-1  | [Sun Apr 27 00:28:54.452298 2025] [php:notice] [pid 1649:tid 1649] [client 192.168.21.5:45290] PHP   6. Sabre\\DAV\\CorePlugin->exception($e = class Sabre\\DAV\\Exception\\NotFound { protected $message = 'File with name /Notes/New note (2).md could not be located'; private string ${Exception}string = ''; protected $code = 0; protected string $file = '/var/www/html/apps/dav/lib/Connector/Sabre/Directory.php'; protected int $line = 195; private array ${Exception}trace = [0 => [...], 1 => [...], 2 => [...], 3 => [...], 4 => [...], 5 => [...], 6 => [...], 7 => [...], 8 => [...], 9 => [...], 10 => [...]]; private ?Throwable ${Exception}previous = NULL }) /var/www/html/3rdparty/sabre/event/lib/WildcardEmitterTrait.php:89
nextcloud-1  | [Sun Apr 27 00:28:54.452300 2025] [php:notice] [pid 1649:tid 1649] [client 192.168.21.5:45290] PHP   7. Sabre\\DAV\\Server->getLogger() /var/www/html/3rdparty/sabre/dav/lib/DAV/CorePlugin.php:879
nextcloud-1  | [Sun Apr 27 00:28:54.452301 2025] [php:notice] [pid 1649:tid 1649] [client 192.168.21.5:45290] PHP   8. Composer\\Autoload\\ClassLoader->loadClass($class = 'Psr\\\\Log\\\\NullLogger') /var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php:441
nextcloud-1  | [Sun Apr 27 00:28:54.452303 2025] [php:notice] [pid 1649:tid 1649] [client 192.168.21.5:45290] PHP   9. Composer\\Autoload\\{closure:/var/www/html/lib/composer/composer/ClassLoader.php:575-577}($file = '/var/www/html/apps-extra/tables/vendor/composer/../psr/log/Psr/Log/NullLogger.php') /var/www/html/lib/composer/composer/ClassLoader.php:427
nextcloud-1  | [Sun Apr 27 00:28:54.452304 2025] [php:notice] [pid 1649:tid 1649] [client 192.168.21.5:45290] PHP  10. include() /var/www/html/lib/composer/composer/ClassLoader.php:576
nextcloud-1  | [Sun Apr 27 00:28:54.452305 2025] [php:notice] [pid 1649:tid 1649] [client 192.168.21.5:45290] PHP  11. Composer\\Autoload\\ClassLoader->loadClass($class = 'Psr\\\\Log\\\\AbstractLogger') /var/www/html/apps-extra/tables/vendor/psr/log/Psr/Log/NullLogger.php:13
nextcloud-1  | [Sun Apr 27 00:28:54.452306 2025] [php:notice] [pid 1649:tid 1649] [client 192.168.21.5:45290] PHP  12. Composer\\Autoload\\{closure:/var/www/html/lib/composer/composer/ClassLoader.php:575-577}($file = '/var/www/html/apps-extra/tables/vendor/composer/../psr/log/Psr/Log/AbstractLogger.php') /var/www/html/lib/composer/composer/ClassLoader.php:427
nextcloud-1  | [Sun Apr 27 00:28:54.452308 2025] [php:notice] [pid 1649:tid 1649] [client 192.168.21.5:45290] PHP  13. include() /var/www/html/lib/composer/composer/ClassLoader.php:576
nextcloud-1  | 192.168.21.5 - - [27/Apr/2025:00:28:54 +0000] "PROPFIND /remote.php/dav/files/admin/Notes/New%20note%20(2).md HTTP/1.1" 500 456 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/133.0.0.0 Safari/537.36"
nextcloud-1  | {"reqId":"IJU26PsWJrmLlryF83e0","level":3,"time":"2025-04-27T00:28:54+00:00","remoteAddr":"192.168.21.5","user":"admin","app":"PHP","method":"PROPFIND","url":"/remote.php/dav/files/admin/Notes/New%20note%20(2).md","message":"Declaration of Psr\\Log\\AbstractLogger::emergency($message, array $context = []) must be compatible with Psr\\Log\\LoggerInterface::emergency(Stringable|string $message, array $context = []): void at /var/www/html/apps-extra/tables/vendor/psr/log/Psr/Log/AbstractLogger.php#22","userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/133.0.0.0 Safari/537.36","version":"32.0.0.0","data":{"app":"PHP"}}
nextcloud-1  | 192.168.21.5 - - [27/Apr/2025:00:28:57 +0000] "POST /index.php/apps/text/session/450/sync HTTP/1.1" 200 1156 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/133.0.0.0 Safari/537.36"
nextcloud-1  | 192.168.21.5 - - [27/Apr/2025:00:28:58 +0000] "POST /index.php/apps/text/session/237/sync HTTP/1.1" 200 1664 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/133.0.0.0 Safari/537.36"
nextcloud-1  | 192.168.21.5 - - [27/Apr/2025:00:29:01 +0000] "POST /index.php/apps/text/session/237/push HTTP/1.1" 200 822 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/133.0.0.0 Safari/537.36"

enjeck avatar Apr 27 '25 00:04 enjeck

where the value of this.note.internalPath does not actually match the internal path of the currently selected Note.

Okay, got it. To reproduce:

  • create a note (note is automatically named New Note (XX)
  • rename that note
  • now, the internalPath (which includes the Note's name) still used the old Note name, not the updated one. So when we try to share, the internalPath is stale and wrong, hence the errors

enjeck avatar Apr 27 '25 00:04 enjeck