notes icon indicating copy to clipboard operation
notes copied to clipboard

allow using shared notes folder

Open SimeonEhrig opened this issue 9 months ago • 5 comments

Enables the use of a shared folder as a notes folder. Reverts PR #1260 as it is not clear what the problem was and using a shared notes folder is a feature that many users use: #1266

SimeonEhrig avatar May 11 '24 06:05 SimeonEhrig

Please I would love to see this fix merged in!

LMRW avatar Jun 02 '24 13:06 LMRW

Can I help get this merged? Let me know if I can help.

This would fix a critical issue for me which i've spent a lot of time on

LMRW avatar Jun 02 '24 14:06 LMRW

What can we do to fix this to be merged in please?

Its a fix for a show stopping bug that breaks a critical feature

Its also old tested code used before which was removed and would be put back, so its battle tested

Please there seems to be no good reason to not merge this in now

LMRW avatar Jun 09 '24 20:06 LMRW

Any progress here?

SimeonEhrig avatar Jun 21 '24 06:06 SimeonEhrig

@juliushaertl Can you please give us feedback?

areteichi avatar Jun 21 '24 20:06 areteichi

Thanks for the pull request, unfortunately this reintroduces an issue where users without a notes folder could end up with their notes in an incoming share by accident. I've pushed a different approach to the fix to https://github.com/nextcloud/notes/pull/1320 that I'll try to finish up asap and do a new release then.

juliusknorr avatar Jul 11 '24 14:07 juliusknorr

close because PR #1320 solved the problem.

SimeonEhrig avatar Jul 15 '24 14:07 SimeonEhrig